Convert ready operations to promises.

 






 

 


  Review Request #11842
  —
  Created Oct. 4, 2021 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change updates the ready method to use promises and async/await

instead of callbacks. This flattens almost all of our remaining

asynchronous operations.

 








  


 
 

  
    

  • Ran js-tests.
    • 

  • Smoke tested various UI functionality.
    • 


 







 









 





  








 




 







   

    
    
Changes between revision 2 and 3



    

 

 

 

 
orig
1
2
3

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Convert ready operations to promises.
     
This change updates the `ready` method to use promises and async/await
instead of callbacks. This flattens almost all of our remaining
asynchronous operations.

Testing Done:
- Ran js-tests.
- Smoke tested various UI functionality.

    

   
  		
  77a891719a258219346ad07bf22e352422f10c4b
  David Trowbridge
 


 
  
 
 
  
   
    

     Convert ready operations to promises.
     
This change updates the `ready` method to use promises and async/await
instead of callbacks. This flattens almost all of our remaining
asynchronous operations.

Testing Done:
- Ran js-tests.
- Smoke tested various UI functionality.

    

   
  		
  cc05130a062500c31152c7eb5ef99746ba141023
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/pages/models/tests/reviewablePageModelTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/pages/views/tests/diffViewerPageViewTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/pages/views/tests/reviewablePageViewTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/resources/collections/tests/resourceCollectionTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/resources/models/draftResourceChildModelMixin.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/resources/models/draftReviewRequestModel.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/resources/models/reviewRequestModel.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/resources/models/tests/draftReviewModelTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/resources/models/tests/draftReviewRequestModelTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/resources/models/tests/reviewReplyModelTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/resources/models/tests/reviewRequestModelTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviewRequestPage/models/tests/reviewReplyEditorModelTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewViewTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/views/tests/commentIssueBarViewTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/views/tests/reviewDialogViewTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/views/tests/reviewRequestFieldViewsTests.es6.js
     
    

   
  

 










     

    

   

  

  

   
   Loading...