Summary

Convert ready operations to promises.

Review Request #11842 — Created Oct. 4, 2021 and submitted Dec. 3, 2021, 3:48 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change updates the ready method to use promises and async/await
instead of callbacks. This flattens almost all of our remaining
asynchronous operations.

Testing Done


Ran js-tests.
Smoke tested various UI functionality.

Commits

Summary	ID
Convert ready operations to promises. This change updates the `ready` method to use promises and async/await instead of callbacks. This flattens almost all of our remaining asynchronous operations. Testing Done: - Ran js-tests. - Smoke tested various UI functionality.	cc05130a062500c31152c7eb5ef99746ba141023

Issues

Description	From	Last Updated
Col: 55 Missing semicolon.	reviewbot	Oct. 4, 2021, 1:29 p.m.
Col: 15 Missing semicolon.	reviewbot	Oct. 4, 2021, 1:29 p.m.
Col: 73 Missing semicolon.	reviewbot	Oct. 4, 2021, 1:29 p.m.
"unused"? "optional"?	chipx86	Oct. 14, 2021, 12:30 p.m.

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/resources/models/draftResourceChildModelMixin.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 55
 Missing semicolon.
```
reviewboard/static/rb/js/reviewRequestPage/models/reviewReplyEditorModel.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 15
 Missing semicolon.
```
reviewboard/static/rb/js/reviewRequestPage/views/reviewEntryView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 73
 Missing semicolon.
```

Commits:

	Summary	ID
	Convert ready operations to promises. This change updates the `ready` method to use promises and async/await instead of callbacks. This flattens almost all of our remaining asynchronous operations. Testing Done: - Ran js-tests. - Smoke tested various UI functionality.	324d7382231caf5b2f6d1e6912ce27b59f2c71c2
	Convert ready operations to promises. This change updates the `ready` method to use promises and async/await instead of callbacks. This flattens almost all of our remaining asynchronous operations. Testing Done: - Ran js-tests. - Smoke tested various UI functionality.	77a891719a258219346ad07bf22e352422f10c4b

Diff:

Revision 2 (+1682 -2090)

Show changes

	reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.es6.js
	reviewboard/static/rb/js/models/commentEditorModel.es6.js
	reviewboard/static/rb/js/models/commentIssueManagerModel.es6.js
	reviewboard/static/rb/js/models/regionCommentBlockModel.es6.js
	reviewboard/static/rb/js/pages/models/reviewablePageModel.es6.js
	reviewboard/static/rb/js/pages/models/tests/reviewablePageModelTests.es6.js
	reviewboard/static/rb/js/pages/views/tests/diffViewerPageViewTests.es6.js
	reviewboard/static/rb/js/pages/views/tests/reviewablePageViewTests.es6.js
	28 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

reviewboard/static/rb/js/resources/models/draftResourceChildModelMixin.es6.js (Diff revision 2)

The issue has been resolved. Show all issues

"unused"? "optional"?

Commits:

	Summary	ID
	Convert ready operations to promises. This change updates the `ready` method to use promises and async/await instead of callbacks. This flattens almost all of our remaining asynchronous operations. Testing Done: - Ran js-tests. - Smoke tested various UI functionality.	77a891719a258219346ad07bf22e352422f10c4b
	Convert ready operations to promises. This change updates the `ready` method to use promises and async/await instead of callbacks. This flattens almost all of our remaining asynchronous operations. Testing Done: - Ran js-tests. - Smoke tested various UI functionality.	cc05130a062500c31152c7eb5ef99746ba141023

Diff:

Revision 3 (+1640 -2102)

Show changes

	reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.es6.js
	reviewboard/static/rb/js/models/commentEditorModel.es6.js
	reviewboard/static/rb/js/models/commentIssueManagerModel.es6.js
	reviewboard/static/rb/js/models/regionCommentBlockModel.es6.js
	reviewboard/static/rb/js/pages/models/reviewablePageModel.es6.js
	reviewboard/static/rb/js/pages/models/tests/reviewablePageModelTests.es6.js
	reviewboard/static/rb/js/pages/views/tests/diffViewerPageViewTests.es6.js
	reviewboard/static/rb/js/pages/views/tests/reviewablePageViewTests.es6.js
	28 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status: Closed (submitted)

Change Summary:

Pushed to master (ca4cb28)