flake8
passed.
JSHint
failed.
JSHint
-
reviewboard/static/rb/js/resources/models/reviewReplyModel.es6.js (Diff revision 1) Show all issues
Convert remaining publish operations to use promises.
Review Request #11841 — Created Oct. 4, 2021 and submitted
| Information | |
|---|---|
| david | |
| Review Board | |
| master | |
| Reviewers | |
| reviewboard | |
This changes the last remaining publish operations to use promises and
async/await instead of callbacks.
- Ran js-tests.
- Published draft review requests and review replies.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+84 -50) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
reviewboard/static/rb/js/resources/models/draftReviewRequestModel.es6.js (Diff revision 2) optional? -
reviewboard/static/rb/js/resources/models/reviewReplyModel.es6.js (Diff revision 2) Indentation isn't consistent. Looks like
this.save()and its contents should be indented.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+98 -64) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.