Summary

Convert remaining publish operations to use promises.

Review Request #11841 — Created Oct. 4, 2021 and submitted Dec. 3, 2021, 3:48 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This changes the last remaining publish operations to use promises and
async/await instead of callbacks.

Testing Done


Ran js-tests.
Published draft review requests and review replies.

Commits

Summary	ID
Convert remaining publish operations to use promises. This changes the last remaining publish operations to use promises and async/await instead of callbacks. Testing Done: - Ran js-tests. - Published draft review requests and review replies.	946327956f5e99ba9b089e75517740097f55fe43

Issues

Description	From	Last Updated
Col: 65 Missing semicolon.	reviewbot	Oct. 4, 2021, 1:25 p.m.
optional?	chipx86	Oct. 14, 2021, 12:27 p.m.
Indentation isn't consistent. Looks like this.save() and its contents should be indented.	chipx86	Oct. 14, 2021, 12:27 p.m.

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/resources/models/reviewReplyModel.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 65
 Missing semicolon.
```

Commits:

	Summary	ID
	Convert remaining publish operations to use promises. This changes the last remaining publish operations to use promises and async/await instead of callbacks. Testing Done: - Ran js-tests. - Published draft review requests and review replies.	6440e78cfa485eef2cf33795b91ffc19960acf45
	Convert remaining publish operations to use promises. This changes the last remaining publish operations to use promises and async/await instead of callbacks. Testing Done: - Ran js-tests. - Published draft review requests and review replies.	7d11194a64490783d36bbed75d114fbd8654ae91

Diff:

Revision 2 (+84 -50)

Show changes

	reviewboard/static/rb/js/resources/models/draftReviewRequestModel.es6.js
	reviewboard/static/rb/js/resources/models/reviewReplyModel.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyDraftBannerView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/resources/models/draftReviewRequestModel.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
optional?
```

reviewboard/static/rb/js/resources/models/reviewReplyModel.es6.js (Diff revision 2)

The issue has been resolved. Show all issues

Indentation isn't consistent. Looks like this.save() and its contents should be indented.

Commits:

	Summary	ID
	Convert remaining publish operations to use promises. This changes the last remaining publish operations to use promises and async/await instead of callbacks. Testing Done: - Ran js-tests. - Published draft review requests and review replies.	7d11194a64490783d36bbed75d114fbd8654ae91
	Convert remaining publish operations to use promises. This changes the last remaining publish operations to use promises and async/await instead of callbacks. Testing Done: - Ran js-tests. - Published draft review requests and review replies.	946327956f5e99ba9b089e75517740097f55fe43

Diff:

Revision 3 (+98 -64)

Show changes

	reviewboard/static/rb/js/resources/models/draftReviewRequestModel.es6.js
	reviewboard/static/rb/js/resources/models/reviewReplyModel.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyDraftBannerView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (1e6b689)