Convert BaseResource.fetch to return a promise.

 






 

 


  Review Request #11840
  —
  Created Oct. 4, 2021 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change updates the base resource model fetch operation to use

promises and async/await instead of callbacks.

 








  


 
 

  
    

  • Ran js-tests.
    • 

  • Manually tested various parts of the UI that rely on this.
    • 


 







 









 





  








 




 







   

    
    
Diff Revision 3 (Latest)



    

 

 

 

 
orig
1
2
3

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Convert BaseResource.fetch to return a promise.
     
This change updates the base resource model `fetch` operation to use
promises and async/await instead of callbacks.

Testing Done:
- Ran js-tests.
- Manually tested various parts of the UI that rely on this.

    

   
  		
  1fb73e6ad9f92bf4f0ecb881655bcf5c78bc5a48
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/resources/models/baseResourceModel.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/resources/models/tests/draftReviewModelTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/resources/models/tests/reviewReplyModelTests.es6.js
     
    

   
  

 










     

    

   

  

  

   
   Loading...