Summary

Convert BaseResource.fetch to return a promise.

Review Request #11840 — Created Oct. 4, 2021 and submitted Dec. 3, 2021, 3:48 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change updates the base resource model fetch operation to use
promises and async/await instead of callbacks.

Testing Done


Ran js-tests.
Manually tested various parts of the UI that rely on this.

Commits

Summary	ID
Convert BaseResource.fetch to return a promise. This change updates the base resource model `fetch` operation to use promises and async/await instead of callbacks. Testing Done: - Ran js-tests. - Manually tested various parts of the UI that rely on this.	1fb73e6ad9f92bf4f0ecb881655bcf5c78bc5a48

Issues

Description	From	Last Updated
Col: 19 'optional catch binding' is only available in ES10 (use 'esversion: 10').	reviewbot	Oct. 4, 2021, 1:23 p.m.
Jasmine has an expectAsync that supports things like toBeRejected(). I think we can use that here, maybe in other tests? …	chipx86	Oct. 14, 2021, 10:56 a.m.
Col: 19 'optional catch binding' is only available in ES10 (use 'esversion: 10').	reviewbot	Oct. 4, 2021, 1:23 p.m.

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.es6.js (Diff revision 1)
Show all issues
```
Col: 19
 'optional catch binding' is only available in ES10 (use 'esversion: 10').
```
reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.es6.js (Diff revision 1)
Show all issues
```
Col: 19
 'optional catch binding' is only available in ES10 (use 'esversion: 10').
```

reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.es6.js (Diff revision 1)

Show all issues

Jasmine has an expectAsync that supports things like toBeRejected(). I think we can use that here, maybe in other tests? Seems it's in the version we ship.

Commits:

	Summary	ID
	Convert BaseResource.fetch to return a promise. This change updates the base resource model `fetch` operation to use promises and async/await instead of callbacks. Testing Done: - Ran js-tests. - Manually tested various parts of the UI that rely on this.	c47187ebf5f1c97183e8a339204f558fff3ef6cc
	Convert BaseResource.fetch to return a promise. This change updates the base resource model `fetch` operation to use promises and async/await instead of callbacks. Testing Done: - Ran js-tests. - Manually tested various parts of the UI that rely on this.	4014cbe0c28fa142af6c575e8f7677d7cfdc4d54

Diff:

Revision 2 (+446 -434)

Show changes

	reviewboard/static/rb/js/resources/models/baseResourceModel.es6.js
	reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.es6.js
	reviewboard/static/rb/js/resources/models/tests/draftReviewModelTests.es6.js
	reviewboard/static/rb/js/resources/models/tests/reviewReplyModelTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary	ID
	Convert BaseResource.fetch to return a promise. This change updates the base resource model `fetch` operation to use promises and async/await instead of callbacks. Testing Done: - Ran js-tests. - Manually tested various parts of the UI that rely on this.	4014cbe0c28fa142af6c575e8f7677d7cfdc4d54
	Convert BaseResource.fetch to return a promise. This change updates the base resource model `fetch` operation to use promises and async/await instead of callbacks. Testing Done: - Ran js-tests. - Manually tested various parts of the UI that rely on this.	1fb73e6ad9f92bf4f0ecb881655bcf5c78bc5a48

Diff:

Revision 3 (+446 -434)

Show changes

	reviewboard/static/rb/js/resources/models/baseResourceModel.es6.js
	reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.es6.js
	reviewboard/static/rb/js/resources/models/tests/draftReviewModelTests.es6.js
	reviewboard/static/rb/js/resources/models/tests/reviewReplyModelTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (4ec4182)