This change has been marked as completed.

Describe the completed change (optional):

Pushed to master (4ec4182)

Summary

Convert BaseResource.fetch to return a promise.

Review Request #11840 — Created Oct. 4, 2021 and submitted 3 years, 5 months ago — Latest diff uploaded 3 years, 6 months ago

Owner

Repository

Review Board

Branch

master

Bugs

Depends On

Groups

People

Description*

This change updates the base resource model fetch operation to use
promises and async/await instead of callbacks.

Testing Done


Ran js-tests.
Manually tested various parts of the UI that rely on this.

This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.

orig

First	Last	Summary	ID	Author
		Convert BaseResource.fetch to return a promise. This change updates the base resource model `fetch` operation to use promises and async/await instead of callbacks. Testing Done: - Ran js-tests. - Manually tested various parts of the UI that rely on this.	4014cbe0c28fa142af6c575e8f7677d7cfdc4d54	David Trowbridge

	reviewboard/static/rb/js/resources/models/baseResourceModel.es6.js
	reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.es6.js
	reviewboard/static/rb/js/resources/models/tests/draftReviewModelTests.es6.js
	reviewboard/static/rb/js/resources/models/tests/reviewReplyModelTests.es6.js

reviewboard/static/rb/js/resources/models/baseResourceModel.es6.js

reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.es6.js

reviewboard/static/rb/js/resources/models/tests/draftReviewModelTests.es6.js

reviewboard/static/rb/js/resources/models/tests/reviewReplyModelTests.es6.js