Summary:

Convert group membership operations to use promises.

Review Request #11839 — Created Oct. 4, 2021 and submitted Dec. 3, 2021, 3:48 p.m.

Description

This change updates the group join/leave operations to use promises and
async/await instead of callbacks.

Testing Done


Ran js-tests.
Manually tested group membership operations.

Commits

Summary
	Convert group membership operations to use promises.

Screenshots

Issues

Description	From	Last Updated
Col: 27 Missing semicolon.	reviewbot	Oct. 4, 2021, 1:20 p.m.
Col: 15 Missing semicolon.	reviewbot	Oct. 4, 2021, 1:20 p.m.
Col: 72 Missing semicolon.	reviewbot	Oct. 4, 2021, 1:20 p.m.
I think we can use expectAsync(...).toBeRejectedWith(...). If so, then this applies elsewhere.	chipx86	Oct. 14, 2021, 10:25 a.m.

flake8 passed.

JSHint failed.

	Summary
-		Convert group membership operations to use promises.
+		Convert group membership operations to use promises.

Revision 2 (+260 -190)

	reviewboard/static/rb/js/accountPrefsPage/views/joinedGroupsView.es6.js
	reviewboard/static/rb/js/resources/models/reviewGroupModel.es6.js
	reviewboard/static/rb/js/resources/models/tests/reviewGroupModelTests.es6.js

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/resources/models/tests/reviewGroupModelTests.es6.js (Diff revision 2)

Show all issues

I think we can use expectAsync(...).toBeRejectedWith(...).
If so, then this applies elsewhere.

	Summary
-		Convert group membership operations to use promises.
+		Convert group membership operations to use promises.

Revision 3 (+230 -190)

	reviewboard/static/rb/js/accountPrefsPage/views/joinedGroupsView.es6.js
	reviewboard/static/rb/js/resources/models/reviewGroupModel.es6.js
	reviewboard/static/rb/js/resources/models/tests/reviewGroupModelTests.es6.js

flake8 passed.

JSHint passed.

Ship it!

Pushed to master (f7b2720)