Convert group membership operations to use promises.

Review Request #11839 — Created Oct. 4, 2021 and updated

david
Review Board
master
reviewboard

This change updates the group join/leave operations to use promises and
async/await instead of callbacks.

  • Ran js-tests.
  • Manually tested group membership operations.
Summary
Convert group membership operations to use promises.
Description From Last Updated

Col: 27 Missing semicolon.

reviewbotreviewbot

Col: 15 Missing semicolon.

reviewbotreviewbot

Col: 72 Missing semicolon.

reviewbotreviewbot

I think we can use expectAsync(...).toBeRejectedWith(...). If so, then this applies elsewhere.

chipx86chipx86
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

david
chipx86
  1. 
      
  2. reviewboard/static/rb/js/resources/models/tests/reviewGroupModelTests.es6.js (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
     

    I think we can use expectAsync(...).toBeRejectedWith(...).

    If so, then this applies elsewhere.

  3. 
      
david
Review request changed

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
Loading...