Summary

Convert group membership operations to use promises.

Review Request #11839 — Created Oct. 4, 2021 and submitted Dec. 3, 2021, 3:48 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change updates the group join/leave operations to use promises and
async/await instead of callbacks.

Testing Done


Ran js-tests.
Manually tested group membership operations.

Commits

Summary	ID
Convert group membership operations to use promises. This change updates the group join/leave operations to use promises and async/await instead of callbacks. Testing Done: - Ran js-tests. - Manually tested group membership operations.	ccbdd80764e1b73c88f7f925dc506f7fac2115a3

Issues

Description	From	Last Updated
Col: 27 Missing semicolon.	reviewbot	Oct. 4, 2021, 1:20 p.m.
Col: 15 Missing semicolon.	reviewbot	Oct. 4, 2021, 1:20 p.m.
Col: 72 Missing semicolon.	reviewbot	Oct. 4, 2021, 1:20 p.m.
I think we can use expectAsync(...).toBeRejectedWith(...). If so, then this applies elsewhere.	chipx86	Oct. 14, 2021, 10:25 a.m.

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/resources/models/tests/reviewGroupModelTests.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 27
 Missing semicolon.
```
reviewboard/static/rb/js/resources/models/tests/reviewGroupModelTests.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 15
 Missing semicolon.
```
reviewboard/static/rb/js/resources/models/tests/reviewGroupModelTests.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 72
 Missing semicolon.
```

Commits:

	Summary	ID
	Convert group membership operations to use promises. This change updates the group join/leave operations to use promises and async/await instead of callbacks. Testing Done: - Ran js-tests. - Manually tested group membership operations.	8c0c43717d42700c71c9a81c17966ea0b5ea1eb0
	Convert group membership operations to use promises. This change updates the group join/leave operations to use promises and async/await instead of callbacks. Testing Done: - Ran js-tests. - Manually tested group membership operations.	45917a2c43b00907ca4974750406480fd2bd3eac

Diff:

Revision 2 (+260 -190)

Show changes

	reviewboard/static/rb/js/accountPrefsPage/views/joinedGroupsView.es6.js
	reviewboard/static/rb/js/resources/models/reviewGroupModel.es6.js
	reviewboard/static/rb/js/resources/models/tests/reviewGroupModelTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/resources/models/tests/reviewGroupModelTests.es6.js (Diff revision 2)

The issue has been resolved. Show all issues

I think we can use expectAsync(...).toBeRejectedWith(...).
If so, then this applies elsewhere.

Commits:

	Summary	ID
	Convert group membership operations to use promises. This change updates the group join/leave operations to use promises and async/await instead of callbacks. Testing Done: - Ran js-tests. - Manually tested group membership operations.	45917a2c43b00907ca4974750406480fd2bd3eac
	Convert group membership operations to use promises. This change updates the group join/leave operations to use promises and async/await instead of callbacks. Testing Done: - Ran js-tests. - Manually tested group membership operations.	ccbdd80764e1b73c88f7f925dc506f7fac2115a3

Diff:

Revision 3 (+230 -190)

Show changes

	reviewboard/static/rb/js/accountPrefsPage/views/joinedGroupsView.es6.js
	reviewboard/static/rb/js/resources/models/reviewGroupModel.es6.js
	reviewboard/static/rb/js/resources/models/tests/reviewGroupModelTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (f7b2720)