Convert group membership operations to use promises.

Review Request #11839 — Created Oct. 4, 2021 and submitted

Information

Review Board
master

Reviewers

This change updates the group join/leave operations to use promises and
async/await instead of callbacks.

  • Ran js-tests.
  • Manually tested group membership operations.
Summary ID
Convert group membership operations to use promises.
This change updates the group join/leave operations to use promises and async/await instead of callbacks. Testing Done: - Ran js-tests. - Manually tested group membership operations.
ccbdd80764e1b73c88f7f925dc506f7fac2115a3
Description From Last Updated

Col: 27 Missing semicolon.

reviewbotreviewbot

Col: 15 Missing semicolon.

reviewbotreviewbot

Col: 72 Missing semicolon.

reviewbotreviewbot

I think we can use expectAsync(...).toBeRejectedWith(...). If so, then this applies elsewhere.

chipx86chipx86
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

david
chipx86
  1. 
      
  2. reviewboard/static/rb/js/resources/models/tests/reviewGroupModelTests.es6.js (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
     
    Show all issues

    I think we can use expectAsync(...).toBeRejectedWith(...).

    If so, then this applies elsewhere.

  3. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to master (f7b2720)