Summary

Update our node.js bin paths to reference the .bin directory.

Review Request #11832 — Created Oct. 2, 2021 and submitted Oct. 4, 2021, 7:10 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-2.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

We've been hard-coding paths to node.js-based executable files, pointing

to some place in node_modules/<module>/.... We've seen this change a

couple of times now, particularly with Babel.
There's already a built-in solution to this that makes our lives easier,

reduces maintenance, and better survives module updates. Each executable

has a symlink in node_modules/.bin/, which references the correct path

within the module.
This change updates our static media building to reference these more

stable paths.

Testing Done

Successfully built packages, and verified through ps auxw that the
.bin/ paths were being used.

Commits

Summary	ID
Update our node.js bin paths to reference the .bin directory. We've been hard-coding paths to node.js-based executable files, pointing to some place in `node_modules/<module>/...`. We've seen this change a couple of times now, particularly with Babel. There's already a built-in solution to this that makes our lives easier, reduces maintenance, and better survives module updates. Each executable has a symlink in `node_modules/.bin/`, which references the correct path within the module. This change updates our static media building to reference these more stable paths.	9cb22c7a8df893eb0ca68098a8de4d592fe80f61

Summary

Update our node.js bin paths to reference the .bin directory.

We've been hard-coding paths to node.js-based executable files, pointing to some place in `node_modules/<module>/...`. We've seen this change a couple of times now, particularly with Babel. There's already a built-in solution to this that makes our lives easier, reduces maintenance, and better survives module updates. Each executable has a symlink in `node_modules/.bin/`, which references the correct path within the module. This change updates our static media building to reference these more stable paths.

9cb22c7a8df893eb0ca68098a8de4d592fe80f61

flake8 passed.

JSHint passed.

Change Summary:

Rebased on top of the new babel changes.

Commits:

	Summary	ID
	Update our node.js bin paths to reference the .bin directory. We've been hard-coding paths to node.js-based executable files, pointing to some place in `node_modules/<module>/...`. We've seen this change a couple of times now, particularly with Babel. There's already a built-in solution to this that makes our lives easier, reduces maintenance, and better survives module updates. Each executable has a symlink in `node_modules/.bin/`, which references the correct path within the module. This change updates our static media building to reference these more stable paths.	b195110f77e56f878305acfe47638c37d8002a6a
	Update our node.js bin paths to reference the .bin directory. We've been hard-coding paths to node.js-based executable files, pointing to some place in `node_modules/<module>/...`. We've seen this change a couple of times now, particularly with Babel. There's already a built-in solution to this that makes our lives easier, reduces maintenance, and better survives module updates. Each executable has a symlink in `node_modules/.bin/`, which references the correct path within the module. This change updates our static media building to reference these more stable paths.	9cb22c7a8df893eb0ca68098a8de4d592fe80f61

Diff:

Revision 2 (+8 -10)

Show changes

djblets/pipeline/settings.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.x (3ef5246)