Stop propagation of click events on the MenuButtonView dropdown toggle

Review Request #11820 — Created Sept. 19, 2021 and submitted

Information

Review Board
master

Reviewers

The dropdown toggle in the MenuButtonView splitbutton would let click
events propagate up, and depending on what child node of the toggle was
being clicked, the modal library from Djblets could interpret it as a
request to close the modal.

This is where Djblets handles the click event.

This patch stops click events on the toggle from propagating, so the
Djblets library never has a chance to get confused.

Fixes bug #4944.

Local manual testing on the Review editor publish splitbutton. Ran all
JS unit tests, and wrote a new unit test for this particular case.

Summary ID
Fix issue 4944.
22bd0f104447ee29b9cc1b6e36d0d843d94f5b28
david
  1. Ship It!
  2. 
      
mike_conley
Review request changed
Status:
Completed
Change Summary:
Pushed to release-5.0.x (06ae91d)