Fix review handle bar not draggable on touchscreens
Review Request #11816 — Created Sept. 17, 2021 and updated
Information | |
---|---|
akim.ruslanov | |
Review Board | |
master | |
4692 | |
Reviewers | |
reviewboard, students | |
Review handle bar was draggable with mouse due to the
mouseup, mousedown
andmousemove
events. However, there were no events to allow for
touchscreen access and thus the handle bar was not draggable for
touchscreen devices.We are now utilizing pointer events instead of mouse events to account
for touchscreen input.
Tested in Chrome and Firefox browser using touchscreen accessibility
mode. Also tested mouse events continue working as expected.
Summary | Author |
---|---|
aruslanov@fispan.com | |
aruslanov@fispan.com | |
aruslanov@fispan.com | |
aruslanov@fispan.com | |
aruslanov@fispan.com |
Description | From | Last Updated |
---|---|---|
The Testing Done is a bit too long. We need this to wrap around 75 characters so it fits well … |
|
|
The Description needs to be fleshed out a bit. It shoud clearly communicate to anyone reading what the problem was … |
|
|
The Summary is making a statement, but not describing the change particularly. Similar to the description, I recommend reading through … |
|
|
Blank line between new selectors. It'd also help to document this by adding a comment explaining what this is for, … |
|
|
It might be worth adding a comment just above this block explaining why we're doing this. |
|
|
There's some extra trailing whitespace that was left over here. |
|
|
With the rename, the : ... no longer aligns with ? .... |
|
|
With the rename, these no longer align. |
|
|
The extra blank line added here should be removed. |
|

Description: |
|
||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commits: |
|
||||||||||||||||||
Diff: |
Revision 2 (+85 -77) |
Checks run (2 succeeded)
-
-
The Testing Done is a bit too long. We need this to wrap around 75 characters so it fits well in a commit message.
-
The Description needs to be fleshed out a bit. It shoud clearly communicate to anyone reading what the problem was and how it was addressed (without going too far into the nitty-gritty).
You can look at prior commit messages or some of our open review requests for some inspiration, and I recommend reading through our Writing Good Change Descriptions guide.
-
The Summary is making a statement, but not describing the change particularly. Similar to the description, I recommend reading through our commit or review request history to see the way we describe changes.
-
reviewboard/static/rb/css/pages/diffviewer.less (Diff revision 2) Blank line between new selectors.
It'd also help to document this by adding a comment explaining what this is for, so that nobody has to remember or go through commit messages.
Multi-line format for LessCSS files looks like:
/* * <text> */
-
reviewboard/static/rb/css/pages/diffviewer.less (Diff revision 2) There's some extra trailing whitespace that was left over here.
-
reviewboard/static/rb/js/views/revisionSelectorView.es6.js (Diff revision 2) With the rename, the
: ...
no longer aligns with? ...
. -
reviewboard/static/rb/js/views/revisionSelectorView.es6.js (Diff revision 2) With the rename, these no longer align.
-
reviewboard/static/rb/js/views/revisionSelectorView.es6.js (Diff revision 2) The extra blank line added here should be removed.

Summary: |
|
||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||||||||||||||
Testing Done: |
|
||||||||||||||||||||||||
Commits: |
|
||||||||||||||||||||||||
Diff: |
Revision 3 (+100 -82) |
Checks run (2 succeeded)
-
Thanks, Akim! Is the hit area still too small, or does this seem to address that somehow?
-
reviewboard/static/rb/css/pages/diffviewer.less (Diff revision 2) It might be worth adding a comment just above this block explaining why we're doing this.

Description: |
|
|||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|

Commits: |
|
||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Branch: |
|
||||||||||||||||||||||||||||||
Diff: |
Revision 4 (+100 -82) |