Fix review handle bar not draggable on touchscreens
Review Request #11816 — Created Sept. 17, 2021 and updated
Review handle bar was draggable with mouse due to the
mouseup, mousedown
andmousemove
events. However, there were no events to allow for
touchscreen access and thus the handle bar was not draggable for
touchscreen devices.We are now utilizing pointer events instead of mouse events to account
for touchscreen input.
Tested in Chrome and Firefox browser using touchscreen accessibility
mode. Also tested mouse events continue working as expected.
Summary | ID | Author |
---|---|---|
e28830a1736a35dc4131d183a1956ee9ebfc5ea7 | aruslanov@fispan.com | |
a6b632332a7b81f65c16466f421baba60f05eff2 | aruslanov@fispan.com | |
0152e9b7d47bf7fd3f820ac6fc8886723f7eaf7e | aruslanov@fispan.com | |
9984298fe4465f58a1dac004c3298e15d8ae4491 | aruslanov@fispan.com | |
28268e2821865fb8d290ac763bd51714b92a21aa | aruslanov@fispan.com |
Description | From | Last Updated |
---|---|---|
The Testing Done is a bit too long. We need this to wrap around 75 characters so it fits well … |
chipx86 | |
The Description needs to be fleshed out a bit. It shoud clearly communicate to anyone reading what the problem was … |
chipx86 | |
The Summary is making a statement, but not describing the change particularly. Similar to the description, I recommend reading through … |
chipx86 | |
Blank line between new selectors. It'd also help to document this by adding a comment explaining what this is for, … |
chipx86 | |
It might be worth adding a comment just above this block explaining why we're doing this. |
mike_conley | |
There's some extra trailing whitespace that was left over here. |
chipx86 | |
With the rename, the : ... no longer aligns with ? .... |
chipx86 | |
With the rename, these no longer align. |
chipx86 | |
The extra blank line added here should be removed. |
chipx86 |
- Description:
-
~ WIP: Fixing the revision-handle-bar usability on touchscreens
~ Fixing the revision-handle-bar usability on touchscreens
- Commits:
-
Summary ID Author e28830a1736a35dc4131d183a1956ee9ebfc5ea7 aruslanov@fispan.com a6b632332a7b81f65c16466f421baba60f05eff2 aruslanov@fispan.com e28830a1736a35dc4131d183a1956ee9ebfc5ea7 aruslanov@fispan.com a6b632332a7b81f65c16466f421baba60f05eff2 aruslanov@fispan.com 0152e9b7d47bf7fd3f820ac6fc8886723f7eaf7e aruslanov@fispan.com
Checks run (2 succeeded)
-
-
The Testing Done is a bit too long. We need this to wrap around 75 characters so it fits well in a commit message.
-
The Description needs to be fleshed out a bit. It shoud clearly communicate to anyone reading what the problem was and how it was addressed (without going too far into the nitty-gritty).
You can look at prior commit messages or some of our open review requests for some inspiration, and I recommend reading through our Writing Good Change Descriptions guide.
-
The Summary is making a statement, but not describing the change particularly. Similar to the description, I recommend reading through our commit or review request history to see the way we describe changes.
-
Blank line between new selectors.
It'd also help to document this by adding a comment explaining what this is for, so that nobody has to remember or go through commit messages.
Multi-line format for LessCSS files looks like:
/* * <text> */
-
-
-
-
- Summary:
-
Revision handle bar is draggable on touchscreenFix review handle bar not draggable on touchscreens
- Description:
-
~ Fixing the revision-handle-bar usability on touchscreens
~ Review handle bar was draggable with mouse due to the
mouseup, mousedown, mousemove
events. However, there were no events to allow for touchscreen access and thus the handle bar was not draggable for touchscreen devices.+ We are now utilizing pointer events instead of mouse events to account for touchscreen input. - Testing Done:
-
~ Testing was done in browser using touchscreen accessibility mode. The page is not scrollable but the handle is.
~ Tested in browser using touchscreen accessibility mode.
- Commits:
-
Summary ID Author e28830a1736a35dc4131d183a1956ee9ebfc5ea7 aruslanov@fispan.com a6b632332a7b81f65c16466f421baba60f05eff2 aruslanov@fispan.com 0152e9b7d47bf7fd3f820ac6fc8886723f7eaf7e aruslanov@fispan.com e28830a1736a35dc4131d183a1956ee9ebfc5ea7 aruslanov@fispan.com a6b632332a7b81f65c16466f421baba60f05eff2 aruslanov@fispan.com 0152e9b7d47bf7fd3f820ac6fc8886723f7eaf7e aruslanov@fispan.com 9984298fe4465f58a1dac004c3298e15d8ae4491 aruslanov@fispan.com
Checks run (2 succeeded)
- Description:
-
~ Review handle bar was draggable with mouse due to the
mouseup, mousedown, mousemove
events. However, there were no events to allow for touchscreen access and thus the handle bar was not draggable for touchscreen devices.~ We are now utilizing pointer events instead of mouse events to account for touchscreen input. ~ Review handle bar was draggable with mouse due to the
mouseup, mousedown
~ and mousemove
events. However, there were no events to allow for+ touchscreen access and thus the handle bar was not draggable for + touchscreen devices. + + We are now utilizing pointer events instead of mouse events to account
+ for touchscreen input. - Testing Done:
-
~ Tested in browser using touchscreen accessibility mode.
~ Tested in Chrome and Firefox browser using touchscreen accessibility
+ mode. Also tested mouse events continue working as expected.
- Commits:
-
Summary ID Author e28830a1736a35dc4131d183a1956ee9ebfc5ea7 aruslanov@fispan.com a6b632332a7b81f65c16466f421baba60f05eff2 aruslanov@fispan.com 0152e9b7d47bf7fd3f820ac6fc8886723f7eaf7e aruslanov@fispan.com 9984298fe4465f58a1dac004c3298e15d8ae4491 aruslanov@fispan.com e28830a1736a35dc4131d183a1956ee9ebfc5ea7 aruslanov@fispan.com a6b632332a7b81f65c16466f421baba60f05eff2 aruslanov@fispan.com 0152e9b7d47bf7fd3f820ac6fc8886723f7eaf7e aruslanov@fispan.com 9984298fe4465f58a1dac004c3298e15d8ae4491 aruslanov@fispan.com 28268e2821865fb8d290ac763bd51714b92a21aa aruslanov@fispan.com - Branch:
-
release-4.0.xmaster