Add a Review Bot tool for looking at Review Request field formatting

Review Request #11815 — Created Sept. 17, 2021 and updated — Latest diff uploaded

Information

ReviewBot
master

Reviewers

Adds a tool to Review Bot that checks line lengths on the Description
and Testing Done fields for review requests, and opens general comments
when they exceed a limit (defaulting to 79 characters). Those general
comments include suggested wrapping.

Included an automated test that tests both short and long strings for
the Description and Testing Done fields. I also tested this manually.

Diff Revision 4

This is not the most recent revision of the diff. The latest diff is revision 5. See what's changed.

orig
1
2
3
4
5

Commits

First Last Summary ID Author
Make it possible to create Tools that run on every review request update.
a9a72c80d098db1cc1629604b68d3629aabcf189 Mike Conley
First stab at a review request line length formatter tool thing.
868a4307b7b94a820072cbafa5f3b9ef8f338e65 Mike Conley
Linting and documentation fixes
0014db2779e4e12a4a381980c3617c1530e42121 Mike Conley
Rename run_on_all_review_request_changes to always_run
47ea3783f7df75e13577ccce65e2fae5383206d1 Mike Conley
Make tool offer a suggestion on a better wrapping.
aa64609da7f66bf0c2d43e27369bce878837092c Mike Conley
Add a test and some other polish.
84e7aaef77f8a1347b19ba273b1100fd34bc34ad Mike Conley
bot/setup.py
bot/reviewbot/tasks.py
bot/reviewbot/processing/review.py
bot/reviewbot/testing/testcases.py
bot/reviewbot/tools/rbfieldformatter.py
bot/reviewbot/tools/base/tool.py
bot/reviewbot/tools/tests/test_rbfieldformatter.py
extension/reviewbotext/integration.py
extension/reviewbotext/models.py
extension/reviewbotext/resources.py
extension/reviewbotext/evolutions/__init__.py
extension/reviewbotext/evolutions/tool_always_run.py
Loading...