flake8
-
bot/reviewbot/tools/rbfieldformatter.py (Diff revision 1) Show all issues -
bot/reviewbot/tools/rbfieldformatter.py (Diff revision 1) F401 'reviewbot.config.config' imported but unused
-
-
-
-
Review Request #11815 — Created Sept. 17, 2021 and updated
Information | |
---|---|
mike_conley | |
ReviewBot | |
master | |
Reviewers | |
reviewbot | |
Adds a tool to Review Bot that checks line lengths on the Description
and Testing Done fields for review requests, and opens general comments
when they exceed a limit (defaulting to 79 characters). Those general
comments include suggested wrapping.
Included an automated test that tests both short and long strings for
the Description and Testing Done fields. I also tested this manually.
Summary |
---|
Description | From | Last Updated |
---|---|---|
F401 'six' imported but unused |
![]() |
|
F401 'reviewbot.config.config' imported but unused |
![]() |
|
E302 expected 2 blank lines, found 1 |
![]() |
|
E501 line too long (84 > 79 characters) |
![]() |
|
E501 line too long (85 > 79 characters) |
![]() |
|
E225 missing whitespace around operator |
![]() |
|
This mixin is probably unnecessary. Better to just have the tool set these members. |
|
|
Let's rename this to always_run. |
|
|
E501 line too long (91 > 79 characters) |
![]() |
|
E501 line too long (92 > 79 characters) |
![]() |
bot/reviewbot/tools/rbfieldformatter.py (Diff revision 1) |
---|
bot/reviewbot/tools/rbfieldformatter.py (Diff revision 1) |
---|
F401 'reviewbot.config.config' imported but unused
Commits: |
|
||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+267 -49) |
bot/reviewbot/tools/base/mixins.py (Diff revision 2) |
---|
This mixin is probably unnecessary. Better to just have the tool set these members.
Commits: |
|
||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+266 -74) |
Summary: |
|
||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||||||||||||
Testing Done: |
|
||||||||||||||||||||||
Commits: |
|
||||||||||||||||||||||
Diff: |
Revision 4 (+742 -96) |
Commits: |
|
||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+756 -98) |