flake8
-
bot/reviewbot/tools/rbfieldformatter.py (Diff revision 1) Show all issues -
bot/reviewbot/tools/rbfieldformatter.py (Diff revision 1) F401 'reviewbot.config.config' imported but unused
-
-
-
-
Review Request #11815 — Created Sept. 17, 2021 and updated
Adds a tool to Review Bot that checks line lengths on the Description
and Testing Done fields for review requests, and opens general comments
when they exceed a limit (defaulting to 79 characters). Those general
comments include suggested wrapping.
Included an automated test that tests both short and long strings for
the Description and Testing Done fields. I also tested this manually.
Summary | ID |
---|---|
a9a72c80d098db1cc1629604b68d3629aabcf189 | |
868a4307b7b94a820072cbafa5f3b9ef8f338e65 | |
0014db2779e4e12a4a381980c3617c1530e42121 | |
47ea3783f7df75e13577ccce65e2fae5383206d1 | |
aa64609da7f66bf0c2d43e27369bce878837092c | |
84e7aaef77f8a1347b19ba273b1100fd34bc34ad | |
f4c0f8b03c239fdb2aa82354f2186906bc53fb2c |
Description | From | Last Updated |
---|---|---|
F401 'six' imported but unused |
![]() |
|
F401 'reviewbot.config.config' imported but unused |
![]() |
|
E302 expected 2 blank lines, found 1 |
![]() |
|
E501 line too long (84 > 79 characters) |
![]() |
|
E501 line too long (85 > 79 characters) |
![]() |
|
E225 missing whitespace around operator |
![]() |
|
This mixin is probably unnecessary. Better to just have the tool set these members. |
|
|
Let's rename this to always_run. |
|
|
E501 line too long (91 > 79 characters) |
![]() |
|
E501 line too long (92 > 79 characters) |
![]() |
bot/reviewbot/tools/rbfieldformatter.py (Diff revision 1) |
---|
bot/reviewbot/tools/rbfieldformatter.py (Diff revision 1) |
---|
F401 'reviewbot.config.config' imported but unused
Commits: |
|
|||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+267 -49) |
bot/reviewbot/tools/base/mixins.py (Diff revision 2) |
---|
This mixin is probably unnecessary. Better to just have the tool set these members.
Commits: |
|
|||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+266 -74) |
Summary: |
|
|||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||||||||||||||||
Testing Done: |
|
|||||||||||||||||||||||
Commits: |
|
|||||||||||||||||||||||
Diff: |
Revision 4 (+742 -96) |
Commits: |
|
|||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+756 -98) |