Summary

Replacing non-named usages to use names logging in files in reviewboard.avatars

Review Request #11809 — Created Sept. 17, 2021 and submitted March 24, 2022, 1:24 p.m.

Information

Owner

matthewgoodman13

Repository

Review Board

Branch

release-4.0.x

Bugs

4901

Depends On

Commit

29ea041...

Reviewers

Groups

reviewboard

People

Description

This commit is replacing non-named usages in reviewboard/avatars to use
named logging instead. The purpose of this change is to automatically include
more information about the module where the logging message came from so that
the messages can be of more use when diagnosing problems from logs.

Testing Done

Ran ./tests/runtests.py reviewboard.avatars.tests and passed all 21 tests.
Checked previous reviews for consistency.

Issues

Description	From	Last Updated
Looks like the bug number is missing from the "Bugs" field. Can you fill that in for later reference?	chipx86	Sept. 17, 2021, 1:59 p.m.
Description and testing look great! One thing that can help with readability is to use backticks around file paths/modules/commands to …	chipx86	Sept. 17, 2021, 2 p.m.
Typo in Testing Done: "consistancy" -> "consistency"	chipx86	Sept. 17, 2021, 2 p.m.
The parameter on the second line is no longer aligned with the first. This applies to the other logger changes …	chipx86	Sept. 17, 2021, 2:23 p.m.
Looks like a blank line probably got removed accidentally. Can you put it back?	chipx86	Sept. 18, 2021, 1:22 p.m.
W293 blank line contains whitespace	reviewbot	Sept. 18, 2021, 1:24 p.m.

flake8 passed.

JSHint passed.

Show all issues

Looks like the bug number is missing from the "Bugs" field. Can you fill that in for later reference?

Show all issues

Description and testing look great! One thing that can help with readability is to use backticks around file paths/modules/commands to help separate it from the other text (particularly useful for the ./tests/runtests.py reviewboard.avatars.tests in "Testing Done".

Show all issues

Typo in Testing Done: "consistancy" -> "consistency"

reviewboard/avatars/templatetags/avatars.py (Diff revision 1)

Show all issues

The parameter on the second line is no longer aligned with the first. This applies to the other logger changes as well.

Change Summary:

fixed alignment of logger lines as per review suggestion

Commit:

-	a6488489b36b88ed56b2957bd73af02852366465
+	c35134373aa4b733381dff195584dd81b6a709fe

Diff:

Revision 2 (+10 -9)

Show changes

reviewboard/avatars/templatetags/avatars.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Re-added other fixes as per comments

Description:

~		This commit is replacing non-named usages in reviewboard/avatars to use
	~	This commit is replacing non-named usages in `reviewboard/avatars` to use
		named logging instead. The purpose of this change is to automatically include
		more information about the module where the logging message came from so that
		the messages can be of more use when diagnosing problems from logs.

Testing Done:

~		Ran ./tests/runtests.py reviewboard.avatars.tests and passed all 21 tests.
~		Checked previous reviews for consistancy.
	~	Ran `./tests/runtests.py reviewboard.avatars.tests` and passed all 21 tests.
	~	Checked previous reviews for consistency.