Replacing non-named usages to use names logging in files in reviewboard.avatars

Review Request #11809 — Created Sept. 17, 2021 and updated

matthewgoodman13
Review Board
release-4.0.x
4901
29ea041...
reviewboard

This commit is replacing non-named usages in reviewboard/avatars to use
named logging instead. The purpose of this change is to automatically include
more information about the module where the logging message came from so that
the messages can be of more use when diagnosing problems from logs.

Ran ./tests/runtests.py reviewboard.avatars.tests and passed all 21 tests.
Checked previous reviews for consistency.

Description From Last Updated

Looks like the bug number is missing from the "Bugs" field. Can you fill that in for later reference?

chipx86chipx86

Description and testing look great! One thing that can help with readability is to use backticks around file paths/modules/commands to ...

chipx86chipx86

Typo in Testing Done: "consistancy" -> "consistency"

chipx86chipx86

The parameter on the second line is no longer aligned with the first. This applies to the other logger changes ...

chipx86chipx86

Looks like a blank line probably got removed accidentally. Can you put it back?

chipx86chipx86

W293 blank line contains whitespace

reviewbotreviewbot
chipx86
  1. 
      
  2. Looks like the bug number is missing from the "Bugs" field. Can you fill that in for later reference?

  3. Description and testing look great! One thing that can help with readability is to use backticks around file paths/modules/commands to help separate it from the other text (particularly useful for the ./tests/runtests.py reviewboard.avatars.tests in "Testing Done".

  4. Typo in Testing Done: "consistancy" -> "consistency"

  5. reviewboard/avatars/templatetags/avatars.py (Diff revision 1)
     
     
     

    The parameter on the second line is no longer aligned with the first. This applies to the other logger changes as well.

  6. 
      
matthewgoodman13
matthewgoodman13
chipx86
  1. 
      
  2. reviewboard/avatars/templatetags/avatars.py (Diff revision 2)
     
     
     
     

    Looks like a blank line probably got removed accidentally. Can you put it back?

  3. 
      
matthewgoodman13
Review request changed

Change Summary:

added blank line back

Commit:

-c35134373aa4b733381dff195584dd81b6a709fe
+80670e628cc5c6b0db371fb7f8fb244be357cfd2

Diff:

Revision 3 (+11 -9)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

matthewgoodman13
Review request changed

Change Summary:

removed whitespace from blank line

Commit:

-80670e628cc5c6b0db371fb7f8fb244be357cfd2
+29ea04126c9d3e95ad712f43b276595af4b21ec4

Diff:

Revision 4 (+10 -8)

Show changes

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
Loading...