flake8
passed.
JSHint
passed.
Replacing non-named usages to use names logging in files in reviewboard.avatars
Review Request #11809 — Created Sept. 17, 2021 and submitted
This commit is replacing non-named usages in
reviewboard/avatarsto use
named logging instead. The purpose of this change is to automatically include
more information about the module where the logging message came from so that
the messages can be of more use when diagnosing problems from logs.
Ran
./tests/runtests.py reviewboard.avatars.testsand passed all 21 tests.
Checked previous reviews for consistency.
| Description | From | Last Updated |
|---|---|---|
|
Looks like the bug number is missing from the "Bugs" field. Can you fill that in for later reference? |
 chipx86
|
|
|
Description and testing look great! One thing that can help with readability is to use backticks around file paths/modules/commands to … |
chipx86
|
|
|
Typo in Testing Done: "consistancy" -> "consistency" |
chipx86
|
|
|
The parameter on the second line is no longer aligned with the first. This applies to the other logger changes … |
chipx86
|
|
|
Looks like a blank line probably got removed accidentally. Can you put it back? |
chipx86
|
|
|
W293 blank line contains whitespace |
 reviewbot
|
-
-
Looks like the bug number is missing from the "Bugs" field. Can you fill that in for later reference?
-
Description and testing look great! One thing that can help with readability is to use backticks around file paths/modules/commands to help separate it from the other text (particularly useful for the
./tests/runtests.py reviewboard.avatars.testsin "Testing Done". -
-
The parameter on the second line is no longer aligned with the first. This applies to the other
loggerchanges as well.
- Change Summary:
-
fixed alignment of logger lines as per review suggestion
- Commit:
-
a6488489b36b88ed56b2957bd73af02852366465c35134373aa4b733381dff195584dd81b6a709fe
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Change Summary:
-
Re-added other fixes as per comments
- Description:
-
~ This commit is replacing non-named usages in reviewboard/avatars to use
~ This commit is replacing non-named usages in
reviewboard/avatarsto usenamed logging instead. The purpose of this change is to automatically include more information about the module where the logging message came from so that the messages can be of more use when diagnosing problems from logs. - Testing Done:
-
~ Ran ./tests/runtests.py reviewboard.avatars.tests and passed all 21 tests.
~ Checked previous reviews for consistancy. ~ Ran
./tests/runtests.py reviewboard.avatars.testsand passed all 21 tests.~ Checked previous reviews for consistency. - Bugs:
- Change Summary:
-
added blank line back
- Commit:
-
c35134373aa4b733381dff195584dd81b6a709fe80670e628cc5c6b0db371fb7f8fb244be357cfd2