Summary

[Demo] Enhance and fix up the setup experience in prepare-dev.py.

Review Request #11806 — Created Sept. 17, 2021 and discarded March 24, 2022, 1:37 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This modernizes the way we request input and display output on
prepare-dev.py, utilizing more of rb-site's ConsoleUI. This is a
better, more consistent way of displaying information and prompting for
information.

The text has been updated to be more user-friendly, to offer
guidance for when things go wrong, and to provide next steps when the
environment is prepared.

Testing Done

Ran prepare-dev.py and verified that it set up my tree correctly without
any errors.

Commits

Summary	ID
[Demo] Enhance and fix up the setup experience in prepare-dev.py. This modernizes the way we request input and display output on `prepare-dev.ppy`, utilizing more of rb-site's `ConsoleUI`. This is a better, more consistent way of displaying information and prompting for information. The text has been updated to be more user-friendly, to offer guidance for when things go wrong, and to provide next steps when the environment is prepared.	e30f2fcf4418c1fd419ba7d034fbcabb3accca92
Fixes from review feedback.	e77f748462f8a4a61f0dca6076dfd58b00a308da

Summary

[Demo] Enhance and fix up the setup experience in prepare-dev.py.

This modernizes the way we request input and display output on `prepare-dev.ppy`, utilizing more of rb-site's `ConsoleUI`. This is a better, more consistent way of displaying information and prompting for information. The text has been updated to be more user-friendly, to offer guidance for when things go wrong, and to provide next steps when the environment is prepared.

e30f2fcf4418c1fd419ba7d034fbcabb3accca92

Fixes from review feedback.

e77f748462f8a4a61f0dca6076dfd58b00a308da

Issues

Description	From	Last Updated
Typo in description: prepare-dev.ppy -> prepare-dev.py	david	Sept. 17, 2021, 10:52 a.m.
Please flesh out the testing done section.	david	Sept. 17, 2021, 10:52 a.m.
There needs to be a blank line between the description and "Type"	david	Oct. 19, 2021, 6:58 p.m.
Typo: two spaces between "in" and "the"	david	Sept. 17, 2021, 10:52 a.m.
E126 continuation line over-indented for hanging indent	reviewbot	Sept. 17, 2021, 10:52 a.m.
This will assign to a locally scoped ui variable. You need to add global ui	david	Oct. 19, 2021, 6:57 p.m.
Please add a blank line after return	david	Sept. 17, 2021, 10:53 a.m.
Because these get concatenated, you need a space at the end of the first string.	david	Sept. 17, 2021, 10:53 a.m.

flake8 failed.

JSHint passed.

flake8

contrib/internal/prepare-dev.py (Diff revision 1)

Show all issues

E126 continuation line over-indented for hanging indent

Fix it!

Most of this looks good, but please pay close attention to the global variable issue.

Show all issues

Typo in description: prepare-dev.ppy -> prepare-dev.py

Show all issues

Please flesh out the testing done section.

contrib/internal/prepare-dev.py (Diff revision 1)

Show all issues

There needs to be a blank line between the description and "Type"

contrib/internal/prepare-dev.py (Diff revision 1)
Show all issues
```
Typo: two spaces between "in" and "the"
```

contrib/internal/prepare-dev.py (Diff revision 1)

What does os.system do?

chipx86 Sept. 17, 2021, 10:50 a.m.

It's used to execute processes, similar to running a command in a shell. It's not always the right approach — the subprocess module is sometimes the better solution here.

contrib/internal/prepare-dev.py (Diff revision 1)

Show all issues

This will assign to a locally scoped ui variable. You need to add global ui

contrib/internal/prepare-dev.py (Diff revision 1)
Show all issues
```
Please add a blank line after return
```

contrib/internal/prepare-dev.py (Diff revision 1)

Show all issues

Because these get concatenated, you need a space at the end of the first string.

Change Summary:


Fixed typos in docstrings and docs.
Added global ui before assigning ConsoleUI.

Description:

		This modernizes the way we request input and display output on
~		`prepare-dev.ppy`, utilizing more of rb-site's `ConsoleUI`. This is a
	~	`prepare-dev.py`, utilizing more of rb-site's `ConsoleUI`. This is a
		better, more consistent way of displaying information and prompting for
		information.

		The text has been updated to be more user-friendly, to offer
		guidance for when things go wrong, and to provide next steps when the
		environment is prepared.

Testing Done:

~		Fixed the bug.
	~	Ran `prepare-dev.py` and verified that it set up my tree correctly without
	+	any errors.

Commits:

	Summary	ID
	[Demo] Enhance and fix up the setup experience in prepare-dev.py. This modernizes the way we request input and display output on `prepare-dev.ppy`, utilizing more of rb-site's `ConsoleUI`. This is a better, more consistent way of displaying information and prompting for information. The text has been updated to be more user-friendly, to offer guidance for when things go wrong, and to provide next steps when the environment is prepared.	e30f2fcf4418c1fd419ba7d034fbcabb3accca92
	[Demo] Enhance and fix up the setup experience in prepare-dev.py. This modernizes the way we request input and display output on `prepare-dev.ppy`, utilizing more of rb-site's `ConsoleUI`. This is a better, more consistent way of displaying information and prompting for information. The text has been updated to be more user-friendly, to offer guidance for when things go wrong, and to provide next steps when the environment is prepared.	e30f2fcf4418c1fd419ba7d034fbcabb3accca92
	Fixes from review feedback.	e77f748462f8a4a61f0dca6076dfd58b00a308da

Diff:

Revision 2 (+139 -49)

Show changes

contrib/internal/prepare-dev.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Review Board 6.0.1 alpha 0 (dev)

[Demo] Enhance and fix up the setup experience in prepare-dev.py.

Information

Reviewers

flake8

Change Summary:

Description:

Testing Done:

Commits:

Diff:

Checks run (2 succeeded)

Status: Discarded