flake8
-
contrib/internal/prepare-dev.py (Diff revision 1) Show all issues
Review Request #11806 — Created Sept. 17, 2021 and discarded
Information | |
---|---|
chipx86 | |
Review Board | |
release-4.0.x | |
Reviewers | |
reviewboard | |
This modernizes the way we request input and display output on
prepare-dev.py
, utilizing more of rb-site'sConsoleUI
. This is a
better, more consistent way of displaying information and prompting for
information.The text has been updated to be more user-friendly, to offer
guidance for when things go wrong, and to provide next steps when the
environment is prepared.
Ran
prepare-dev.py
and verified that it set up my tree correctly without
any errors.
Summary | |
---|---|
Description | From | Last Updated |
---|---|---|
Typo in description: prepare-dev.ppy -> prepare-dev.py |
|
|
Please flesh out the testing done section. |
|
|
There needs to be a blank line between the description and "Type" |
|
|
Typo: two spaces between "in" and "the" |
|
|
E126 continuation line over-indented for hanging indent |
![]() |
|
This will assign to a locally scoped ui variable. You need to add global ui |
|
|
Please add a blank line after return |
|
|
Because these get concatenated, you need a space at the end of the first string. |
|
Most of this looks good, but please pay close attention to the global variable issue.
contrib/internal/prepare-dev.py (Diff revision 1) |
---|
There needs to be a blank line between the description and "Type"
contrib/internal/prepare-dev.py (Diff revision 1) |
---|
This will assign to a locally scoped
ui
variable. You need to addglobal ui
contrib/internal/prepare-dev.py (Diff revision 1) |
---|
Because these get concatenated, you need a space at the end of the first string.
global ui
before assigning ConsoleUI
.Description: |
|
|||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
|||||||||||||||||||||||||||
Commits: |
|
|||||||||||||||||||||||||||
Diff: |
Revision 2 (+139 -49) |