[Demo] Enhance and fix up the setup experience in prepare-dev.py.
Review Request #11806 — Created Sept. 17, 2021 and discarded
This modernizes the way we request input and display output on
prepare-dev.py
, utilizing more of rb-site'sConsoleUI
. This is a
better, more consistent way of displaying information and prompting for
information.The text has been updated to be more user-friendly, to offer
guidance for when things go wrong, and to provide next steps when the
environment is prepared.
Ran
prepare-dev.py
and verified that it set up my tree correctly without
any errors.
Summary | ID |
---|---|
e30f2fcf4418c1fd419ba7d034fbcabb3accca92 | |
e77f748462f8a4a61f0dca6076dfd58b00a308da |
Description | From | Last Updated |
---|---|---|
Typo in description: prepare-dev.ppy -> prepare-dev.py |
david | |
Please flesh out the testing done section. |
david | |
There needs to be a blank line between the description and "Type" |
david | |
Typo: two spaces between "in" and "the" |
david | |
E126 continuation line over-indented for hanging indent |
reviewbot | |
This will assign to a locally scoped ui variable. You need to add global ui |
david | |
Please add a blank line after return |
david | |
Because these get concatenated, you need a space at the end of the first string. |
david |
- Change Summary:
-
- Fixed typos in docstrings and docs.
- Added
global ui
before assigningConsoleUI
.
- Description:
-
This modernizes the way we request input and display output on
~ prepare-dev.ppy
, utilizing more of rb-site'sConsoleUI
. This is a~ prepare-dev.py
, utilizing more of rb-site'sConsoleUI
. This is abetter, more consistent way of displaying information and prompting for information. The text has been updated to be more user-friendly, to offer
guidance for when things go wrong, and to provide next steps when the environment is prepared. - Testing Done:
-
~ Fixed the bug.
~ Ran
prepare-dev.py
and verified that it set up my tree correctly without+ any errors. - Commits:
-
Summary ID e30f2fcf4418c1fd419ba7d034fbcabb3accca92 e30f2fcf4418c1fd419ba7d034fbcabb3accca92 e77f748462f8a4a61f0dca6076dfd58b00a308da - Diff:
-
Revision 2 (+139 -49)