Expand arguments support for SCMTool.popen().

 






 

 


  Review Request #11804
  —
  Created Sept. 1, 2021 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  release-4.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
SCMTool.popen() previously had a hard-coded list of arguments that

were supported, which wasn't particularly helpful for many use cases.

Now, it takes **kwargs and passes them to subprocess.Popen. This

also allows for overriding the pipes, if needed by the caller.

 








  


 
 

  
Made use of this in an upcoming SCM implementation.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Expand arguments support for SCMTool.popen().
     
`SCMTool.popen()` previously had a hard-coded list of arguments that
were supported, which wasn't particularly helpful for many use cases.
Now, it takes `**kwargs` and passes them to `subprocess.Popen`. This
also allows for overriding the pipes, if needed by the caller.

    

   
  		
  bb94b0babe7b68f0f970b7c258000ceca033c513
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/scmtools/core.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...