Summary

Expand arguments support for SCMTool.popen().

Review Request #11804 — Created Sept. 1, 2021 and submitted Sept. 1, 2021, 8:09 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

SCMTool.popen() previously had a hard-coded list of arguments that
were supported, which wasn't particularly helpful for many use cases.
Now, it takes **kwargs and passes them to subprocess.Popen. This
also allows for overriding the pipes, if needed by the caller.

Testing Done

Made use of this in an upcoming SCM implementation.

Commits

Summary	ID
Expand arguments support for SCMTool.popen(). `SCMTool.popen()` previously had a hard-coded list of arguments that were supported, which wasn't particularly helpful for many use cases. Now, it takes `**kwargs` and passes them to `subprocess.Popen`. This also allows for overriding the pipes, if needed by the caller.	bb94b0babe7b68f0f970b7c258000ceca033c513

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (9ca5cac)