Expand arguments support for SCMTool.popen().

Review Request #11804 — Created Sept. 1, 2021 and submitted

Information

Review Board
release-4.0.x

Reviewers

SCMTool.popen() previously had a hard-coded list of arguments that
were supported, which wasn't particularly helpful for many use cases.
Now, it takes **kwargs and passes them to subprocess.Popen. This
also allows for overriding the pipes, if needed by the caller.

Made use of this in an upcoming SCM implementation.

Summary ID
Expand arguments support for SCMTool.popen().
`SCMTool.popen()` previously had a hard-coded list of arguments that were supported, which wasn't particularly helpful for many use cases. Now, it takes `**kwargs` and passes them to `subprocess.Popen`. This also allows for overriding the pipes, if needed by the caller.
bb94b0babe7b68f0f970b7c258000ceca033c513
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-4.0.x (9ca5cac)