Summary

Suppress errors when trying to generate stats for empty diffs.

Review Request #11796 — Created Aug. 18, 2021 and submitted Sept. 3, 2021, 9:39 a.m.

Information

Owner

david

Repository

DiffX

Branch

release-1.0.x

Bugs

Depends On

Reviewers

Groups

diffx

People

Description

There are cases where a diffx diff section will have empty diff
content--for example, when a file is renamed but doesn't have any
changes to content. The diff stats generation will do the right thing if
a file is added without specifying diff= in the constructor at all,
but was spewing errors with diff=b''. This change updates things to
check for falsiness rather than explicitly checking against None.

Testing Done


Ran with some code that was creating empty (but not None) diffs. Saw no

  more errors.
Ran unit tests.

Commits

Summary	ID
Suppress errors when trying to generate stats for empty diffs. There are cases where a diffx diff section will have empty diff content--for example, when a file is renamed but doesn't have any changes to content. The diff stats generation will do the right thing if a file is added without specifying `diff=` in the constructor at all, but was spewing errors with `diff=b''`. This change updates things to check for falsiness rather than explicitly checking against `None`. Testing Done: - Ran with some code that was creating empty (but not `None`) diffs. Saw no more errors. - Ran unit tests.	11826f22aebbad2586186e6e0fb55dda5173516a

Summary

Suppress errors when trying to generate stats for empty diffs.

There are cases where a diffx diff section will have empty diff content--for example, when a file is renamed but doesn't have any changes to content. The diff stats generation will do the right thing if a file is added without specifying `diff=` in the constructor at all, but was spewing errors with `diff=b''`. This change updates things to check for falsiness rather than explicitly checking against `None`. Testing Done: - Ran with some code that was creating empty (but not `None`) diffs. Saw no more errors. - Ran unit tests.

11826f22aebbad2586186e6e0fb55dda5173516a

flake8 passed.

JSHint passed.

Branch:

-	master
+	pydiffx/release-1.x

Can you add a unit test for this? I'm aiming for 100% test coverage, so tests can be used as a starting point for verifying new implementations.

Change Summary:

Add a test case.

Testing Done:

~		Ran with some code that was creating empty (but not `None`) diffs. Saw no
~		more errors.
	~	Ran with some code that was creating empty (but not `None`) diffs. Saw no more errors.
	~	Ran unit tests.

Commits:

	Summary	ID
	Suppress errors when trying to generate stats for empty diffs. There are cases where a diffx diff section will have empty diff content--for example, when a file is renamed but doesn't have any changes to content. The diff stats generation will do the right thing if a file is added without specifying `diff=` in the constructor at all, but was spewing errors with `diff=b''`. This change updates things to check for falsiness rather than explicitly checking against `None`. Testing Done: Ran with some code that was creating empty (but not `None`) diffs. Saw no more errors.	2b7eb3abbf13e8c4e6037516dd5f6034690e24cd
	Suppress errors when trying to generate stats for empty diffs. There are cases where a diffx diff section will have empty diff content--for example, when a file is renamed but doesn't have any changes to content. The diff stats generation will do the right thing if a file is added without specifying `diff=` in the constructor at all, but was spewing errors with `diff=b''`. This change updates things to check for falsiness rather than explicitly checking against `None`. Testing Done: - Ran with some code that was creating empty (but not `None`) diffs. Saw no more errors. - Ran unit tests.	11826f22aebbad2586186e6e0fb55dda5173516a

Branch:

-	pydiffx/release-1.x
+	release-1.0.x

Diff:

Revision 2 (+34 -4)

Show changes

	python/pydiffx/dom/objects.py
	python/pydiffx/tests/test_dom_objects.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to pydiffx/release-1.x (fe417d4)