-
-
-
reviewboard/diffviewer/diffutils.py (Diff revision 1) The comment isn't really too helpful, and makes the line too long. I think we can just remove it.
-
reviewboard/scmtools/core.py (Diff revision 1) Can you move the comment to the previous line, with a blank line before it?
-
reviewboard/scmtools/core.py (Diff revision 1) Docstrings should describe the purpose of the function.
-
-
-
reviewboard/scmtools/core.py (Diff revision 1) Spaces around = Not really sure what I think about "ADD." I think we don't want to mistake operations for revisions. Maybe "(NEW)" or something. We'd also want to indicate deletes later.
-
reviewboard/scmtools/core.py (Diff revision 1) Blank line before this. I'd actually prefer "revision %s" or something instead of just "%s", but only for non-new files.
-
-
reviewboard/templates/diffviewer/changeindex_entry.html (Diff revision 1) Not a fan of having this as part of the link. Maybe after?
Include revision in View Diff summary head of files
Review Request #1178 — Created Oct. 23, 2009 and discarded
| Information | |
|---|---|
| clach04 | |
| Review Board | |
| release-1.0.5.1 | |
| Reviewers | |
| reviewboard | |
| chipx86, david | |
See original change/review http://reviews.reviewboard.org/r/579 which was against svn (and older code). Updated with David Trowbridge's idea to implement and use new SCMTool.format_revision() function for formatting Revisions.
Tested with SVN and another SCM (that uses integers for rev id's) that is not officially supported by ReviewBoard
CL
Change Summary:
* New screenshot * Code updated to address all review comments.
Description: |
|
|||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+21 -1) |
|||||||||||||||
Screenshots: |
|