• 
  
    
 
    
 
    

    



    
    
    
    
     
    




    
 
    

  
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Include revision in View Diff summary head of files
    
 
    

    



 
    
 
    

  Review Request #1178
  —
  Created Oct. 23, 2009 and discarded

 
    


    




    




    




 
    
  
    
   Information

  
    



    
 
 
    
  clach04
 
    

    





    
 
 
    
  Review Board
 
    

    





    
 
 
    
  release-1.0.5.1
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  reviewboard
 
    

    





    
 
 
    
  chipx86, david
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    See original change/review http://reviews.reviewboard.org/r/579 which was against svn (and older code).

Updated with David Trowbridge's idea to implement and use new SCMTool.format_revision() function for formatting Revisions.
    
 
    

    





  

    
 
 
    
  
    Tested with SVN and another SCM (that uses integers for rev id's) that is not officially supported by ReviewBoard
    
 
    

    




 
    

    





    
 
    








 
    
  
    Screenshots
    
  
    

   
    
    
    
    
    
     

    
    
   
    

  
    
 
    


 









 
    

    



  
    
 
    

    


    


 













    
 





 
    
  
    
   
    



chipx86




   
    
   
    



    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
chipx86


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 

















    2. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/diffviewer/diffutils.py
       


        (Diff revision 1)


       
      
     
      
          
    
     
       
      

     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    





    
      Blank line between these.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 






    3. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/diffviewer/diffutils.py
       


        (Diff revision 1)


       
      
     
      
          
    
     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    





    
      The comment isn't really too helpful, and makes the line too long. I think we can just remove it.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      4. 






    4. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/scmtools/core.py
       


        (Diff revision 1)


       
      
     
      
          
    
     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    





    
      Can you move the comment to the previous line, with a blank line before it?
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      5. 






    5. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/scmtools/core.py
       


        (Diff revision 1)


       
      
     
      
          
    
     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    





    
      Docstrings should describe the purpose of the function.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      6. 






    6. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/scmtools/core.py
       


        (Diff revision 1)


       
      
     
      
          
    
     
       
      

     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    





    
      These shouldn't be here.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      7. 






    7. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/scmtools/core.py
       


        (Diff revision 1)


       
      
     
      
          
    
     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    





    
      Spaces around ==
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      8. 






    8. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/scmtools/core.py
       


        (Diff revision 1)


       
      
     
      
          
    
     
       
      

     
       
      

     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    





    
      Spaces around =

Not really sure what I think about "ADD." I think we don't want to mistake operations for revisions. Maybe "(NEW)" or something. We'd also want to indicate deletes later.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      9. 






    9. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/scmtools/core.py
       


        (Diff revision 1)


       
      
     
      
          
    
     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    





    
      Blank line before this. I'd actually prefer "revision %s" or something instead of just "%s", but only for non-new files.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      10. 






    10. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/scmtools/core.py
       


        (Diff revision 1)


       
      
     
      
          
    
     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    





    
      Also shouldn't be here.
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      11. 






    11. 
 
      
  
  
      
  
 
      
  
      
   
      
    
     
      
      
       reviewboard/templates/diffviewer/changeindex_entry.html
       


        (Diff revision 1)


       
      
     
      
          
    
     
       
      

     
       
      

          
   
      
  
      
 
      

   
      
    
    





    
      Not a fan of having this as part of the link. Maybe after?
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      12. 




    12. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      13. 


    

  
    
 
    

    












    
 



 
    
  
    
   
    




 CL





   
    
   
    
  
    
 
    


 
    
  
    

   
    
   
    
    
     Review request changed
    
    
   
    

  
    
  
    
  
    




    



  
    
   
    
    Change Summary:
   
    
   
    
    
    * New screenshot
* Code updated to address all review comments.

    
   
    
  
    







  
    
   
    
    Description:
   
    
   
    
    
         
    See original change/review http://reviews.reviewboard.org/r/579 which was against svn (and older code).
         

         
    Updated with David Trowbridge's idea to implement and use new SCMTool.format_revision() function for formatting Revisions.
     -   

     -   
    I've put a number of commented out code lines for defaults that could be used for the (generic) SCMTool implementation.
    
   
    
  
    




  
    
   
    
    Diff:
   
    
   
    
    
     Revision 2 (+21 -1)
    Show changes
     
        reviewboard/diffviewer/diffutils.py 
        reviewboard/scmtools/core.py 
        reviewboard/templates/diffviewer/changeindex_entry.html 
     
    
   
    
  
    




  
    
   
    
    Screenshots: