• 
      

    Add a with_diff= option to TestCase.create_diffcommit.

    Review Request #11759 — Created July 29, 2021 and submitted

    Information

    Review Board
    release-4.0.x

    Reviewers

    TestCase.create_diffcommit() takes in diff files and runs them through
    the diff parsing and FileDiff creation code, which is sometimes
    overkill (or completely unwanted) for a test.

    This change adds a new with_diff= argument to this method, which can
    turn off this behavior. When passing with_diff=False, the DiffCommit
    will be created in the database directly, without any additional
    processing, and without a FileDiff.

    Unit tests pass.

    Made use of this new argument in an upcoming change.

    Summary ID
    Add a with_diff= option to TestCase.create_diffcommit.
    `TestCase.create_diffcommit()` takes in diff files and runs them through the diff parsing and `FileDiff` creation code, which is sometimes overkill (or completely unwanted) for a test. This change adds a new `with_diff=` argument to this method, which can turn off this behavior. When passing `with_diff=False`, the `DiffCommit` will be created in the database directly, without any additional processing, and without a `FileDiff`.
    654520aa783bd89c0ff2d08182841c7f4117b3f0
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-4.0.x (6129d41)