Summary

Upgrade CodeMirror to 5.62 and fix selections on code literals.

Review Request #11730 — Created July 17, 2021 and submitted July 20, 2021, 1:41 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

We're now including the mark-selection addon, which we're using to fix
the styling of code literals (which would previously hide the
selection). The selected portion will now use the default selection
color.

Testing Done

Tested standard CodeMirror behavior in the comment dialog and review
request fields. Didn't note any regressions.

Went through the release notes for CodeMirror to check what could
regress us, but didn't see anything that was a concern.

Tested selecting text and ensuring that code literals would properly
appear selected.

Commits

Summary	ID
Upgrade CodeMirror to 5.62 and fix selections on code literals. This upgrades our version of CodeMirror from 5.48.2 to 5.62. There's a number of fixes and additions for syntax highlighting, some edge cases fixes for browser compatibility, and several other improvements. We're now including the `mark-selection` addon, which we're using to fix the styling of code literals (which would previously hide the selection). The selected portion will now use the default selection color.	0aa21dce7b96ec27b518f77ee2881d1b3dab9f1f

Summary

Upgrade CodeMirror to 5.62 and fix selections on code literals.

This upgrades our version of CodeMirror from 5.48.2 to 5.62. There's a number of fixes and additions for syntax highlighting, some edge cases fixes for browser compatibility, and several other improvements. We're now including the `mark-selection` addon, which we're using to fix the styling of code literals (which would previously hide the selection). The selected portion will now use the default selection color.

0aa21dce7b96ec27b518f77ee2881d1b3dab9f1f

Issues

Description	From	Last Updated
Col: 58 Expected an assignment or function call and instead saw an expression.	reviewbot	July 17, 2021, 9:18 p.m.
Col: 27 Missing '()' invoking a constructor.	reviewbot	July 17, 2021, 9:18 p.m.
Col: 49 Missing '()' invoking a constructor.	reviewbot	July 17, 2021, 9:18 p.m.
Col: 21 Missing '()' invoking a constructor.	reviewbot	July 17, 2021, 9:18 p.m.
Col: 85 A leading decimal point can be confused with a dot: '.5'.	reviewbot	July 17, 2021, 9:18 p.m.

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/lib/js/codemirror-5.62.0.js (Diff revision 1)

Show all issues

Col: 58
 Expected an assignment or function call and instead saw an expression.

reviewboard/static/lib/js/codemirror-5.62.0.js (Diff revision 1)
Show all issues
```
Col: 27
 Missing '()' invoking a constructor.
```
reviewboard/static/lib/js/codemirror-5.62.0.js (Diff revision 1)
Show all issues
```
Col: 49
 Missing '()' invoking a constructor.
```
reviewboard/static/lib/js/codemirror-5.62.0.js (Diff revision 1)
Show all issues
```
Col: 21
 Missing '()' invoking a constructor.
```
reviewboard/static/lib/js/codemirror-5.62.0.js (Diff revision 1)
Show all issues
```
Col: 85
 A leading decimal point can be confused with a dot: '.5'.
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (fa9c9cb)