Upgrade CodeMirror to 5.62 and fix selections on code literals.

Review Request #11730 — Created July 17, 2021 and submitted

Information

Review Board
release-4.0.x

Reviewers

This upgrades our version of CodeMirror from 5.48.2 to 5.62. There's a
number of fixes and additions for syntax highlighting, some edge cases
fixes for browser compatibility, and several other improvements.

We're now including the mark-selection addon, which we're using to fix
the styling of code literals (which would previously hide the
selection). The selected portion will now use the default selection
color.

Tested standard CodeMirror behavior in the comment dialog and review
request fields. Didn't note any regressions.

Went through the release notes for CodeMirror to check what could
regress us, but didn't see anything that was a concern.

Tested selecting text and ensuring that code literals would properly
appear selected.

Summary ID
Upgrade CodeMirror to 5.62 and fix selections on code literals.
This upgrades our version of CodeMirror from 5.48.2 to 5.62. There's a number of fixes and additions for syntax highlighting, some edge cases fixes for browser compatibility, and several other improvements. We're now including the `mark-selection` addon, which we're using to fix the styling of code literals (which would previously hide the selection). The selected portion will now use the default selection color.
0aa21dce7b96ec27b518f77ee2881d1b3dab9f1f
Description From Last Updated

Col: 58 Expected an assignment or function call and instead saw an expression.

reviewbotreviewbot

Col: 27 Missing '()' invoking a constructor.

reviewbotreviewbot

Col: 49 Missing '()' invoking a constructor.

reviewbotreviewbot

Col: 21 Missing '()' invoking a constructor.

reviewbotreviewbot

Col: 85 A leading decimal point can be confused with a dot: '.5'.

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-4.0.x (fa9c9cb)