Summary

Fix a crash when using Subvertpy 0.11.

Review Request #11725 — Created July 15, 2021 and submitted July 16, 2021, 1:19 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Subvertpy 0.11 introduced some new logic in client.propget() that
normalizes a path to an absolute path. This in turn triggers an eventual
assertion failure in libsvn, which checks to make sure a full repository
URL wasn't passed in (somewhere). This was not a problem in Subvertpy
0.10 (which also didn't have this path normalization).

The problem applies only to propget(), and thankfully does not apply
to proplist(). To work around this crash, we're now calling
proplist() and filtering results from that. This method avoids the
path normalization that broke us, and provides the same results.

The Subvertpy bug is tracked at: https://github.com/jelmer/subvertpy/issues/35

Testing Done

Unit tests pass on Python 2 and 3, against Subverpty 0.10 and 0.11.

Commits

Summary	ID
Fix a crash when using Subvertpy 0.11. Subvertpy 0.11 introduced some new logic in `client.propget()` that normalizes a path to an absolute path. This in turn triggers an eventual assertion failure in libsvn, which checks to make sure a full repository URL wasn't passed in (somewhere). This was not a problem in Subvertpy 0.10 (which also didn't have this path normalization). The problem applies only to `propget()`, and thankfully does not apply to `proplist()`. To work around this crash, we're now calling `proplist()` and filtering results from that. This method avoids the path normalization that broke us, and provides the same results. The Subvertpy bug is tracked at: https://github.com/jelmer/subvertpy/issues/35	7379d51d695dbf2f82f614ee352e7d8163c01994

Summary

Fix a crash when using Subvertpy 0.11.

Subvertpy 0.11 introduced some new logic in `client.propget()` that normalizes a path to an absolute path. This in turn triggers an eventual assertion failure in libsvn, which checks to make sure a full repository URL wasn't passed in (somewhere). This was not a problem in Subvertpy 0.10 (which also didn't have this path normalization). The problem applies only to `propget()`, and thankfully does not apply to `proplist()`. To work around this crash, we're now calling `proplist()` and filtering results from that. This method avoids the path normalization that broke us, and provides the same results. The Subvertpy bug is tracked at: https://github.com/jelmer/subvertpy/issues/35

7379d51d695dbf2f82f614ee352e7d8163c01994

Issues

Description	From	Last Updated
F841 local variable 'e' is assigned to but never used	reviewbot	July 15, 2021, 9:37 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/scmtools/svn/subvertpy.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F841 local variable 'e' is assigned to but never used
```

Change Summary:

Removed an unused variable.

Commits:

	Summary	ID
	Fix a crash when using Subvertpy 0.11. Subvertpy 0.11 introduced some new logic in `client.propget()` that normalizes a path to an absolute path. This in turn triggers an eventual assertion failure in libsvn, which checks to make sure a full repository URL wasn't passed in (somewhere). This was not a problem in Subvertpy 0.10 (which also didn't have this path normalization). The problem applies only to `propget()`, and thankfully does not apply to `proplist()`. To work around this crash, we're now calling `proplist()` and filtering results from that. This method avoids the path normalization that broke us, and provides the same results. The Subvertpy bug is tracked at: https://github.com/jelmer/subvertpy/issues/35	4193461aae1cbe32f65bbe957efc601f7defe509
	Fix a crash when using Subvertpy 0.11. Subvertpy 0.11 introduced some new logic in `client.propget()` that normalizes a path to an absolute path. This in turn triggers an eventual assertion failure in libsvn, which checks to make sure a full repository URL wasn't passed in (somewhere). This was not a problem in Subvertpy 0.10 (which also didn't have this path normalization). The problem applies only to `propget()`, and thankfully does not apply to `proplist()`. To work around this crash, we're now calling `proplist()` and filtering results from that. This method avoids the path normalization that broke us, and provides the same results. The Subvertpy bug is tracked at: https://github.com/jelmer/subvertpy/issues/35	7379d51d695dbf2f82f614ee352e7d8163c01994

Diff:

Revision 2 (+42 -4)

Show changes

reviewboard/scmtools/svn/subvertpy.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (fc9d9da)