• 
      

    Fix a crash when using Subvertpy 0.11.

    Review Request #11725 — Created July 15, 2021 and submitted

    Information

    Review Board
    release-4.0.x

    Reviewers

    Subvertpy 0.11 introduced some new logic in client.propget() that
    normalizes a path to an absolute path. This in turn triggers an eventual
    assertion failure in libsvn, which checks to make sure a full repository
    URL wasn't passed in (somewhere). This was not a problem in Subvertpy
    0.10 (which also didn't have this path normalization).

    The problem applies only to propget(), and thankfully does not apply
    to proplist(). To work around this crash, we're now calling
    proplist() and filtering results from that. This method avoids the
    path normalization that broke us, and provides the same results.

    The Subvertpy bug is tracked at: https://github.com/jelmer/subvertpy/issues/35

    Unit tests pass on Python 2 and 3, against Subverpty 0.10 and 0.11.

    Summary ID
    Fix a crash when using Subvertpy 0.11.
    Subvertpy 0.11 introduced some new logic in `client.propget()` that normalizes a path to an absolute path. This in turn triggers an eventual assertion failure in libsvn, which checks to make sure a full repository URL wasn't passed in (somewhere). This was not a problem in Subvertpy 0.10 (which also didn't have this path normalization). The problem applies only to `propget()`, and thankfully does not apply to `proplist()`. To work around this crash, we're now calling `proplist()` and filtering results from that. This method avoids the path normalization that broke us, and provides the same results. The Subvertpy bug is tracked at: https://github.com/jelmer/subvertpy/issues/35
    7379d51d695dbf2f82f614ee352e7d8163c01994
    Description From Last Updated

    F841 local variable 'e' is assigned to but never used

    reviewbotreviewbot
    Checks run (1 failed, 1 succeeded)
    flake8 failed.
    JSHint passed.

    flake8

    chipx86
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-4.0.x (fc9d9da)