Add **kwargs parameter to create function in test case.
Review Request #11716 — Created July 11, 2021 and submitted
Information | |
---|---|
cathyqinqin | |
Review Board | |
master | |
Reviewers | |
reviewboard | |
In test case, some
create_*()
functions does not have**kwargs
parameter,
and that restrict user to pass extra key-value pair arguments,
adding**kwargs
paramter can avoid that situation happen again.
All 5657 tests are done, only 1 test related with not install pysvn has error.
Summary | Author | |
---|---|---|
cathyQinQin |
Description | From | Last Updated |
---|---|---|
A few issues in the review request description: The description needs to wrap at 79 characters. Any bits of code … |
|
|
Typo in the summary: "creat" should be "create". |
|
|
Looks good! One thing that's important for any new code though is documentation updates. Every method that gained **kwargs should … |
|
|
W293 blank line contains whitespace |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
W293 blank line contains whitespace |
![]() |
-
-
A few issues in the review request description:
- The description needs to wrap at 79 characters.
- Any bits of code needs to be wrapped in backticks, to turn it into a code literal (like
foo
). This is especially important for**kwargs
, because**
in Markdown is bold. You'll see how that broke rendering in your description.
-
-
Looks good! One thing that's important for any new code though is documentation updates. Every method that gained
**kwargs
should have it added to theArgs:
part of the docs.There are some older methods that don't have
Args:
, and you can ignore those.Look at existing methods with
**kwargs
for some text you can probably copy/paste.

Summary: |
|
||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
||||||||||||
Commits: |
|
||||||||||||
Diff: |
Revision 2 (+80 -30) |
Checks run (1 failed, 1 succeeded)
flake8
-
The new change looks good, but make sure you fix up those Review Bot complaints. We should be able to land this right after! :)

Testing Done: |
|
||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commits: |
|
||||||||||||||||
Diff: |
Revision 3 (+80 -30) |