Add **kwargs parameter to create function in test case.

Review Request #11716 — Created July 11, 2021 and updated

cathyqinqin
Review Board
master
reviewboard

In test case, some create_*() functions does not have **kwargs parameter,
and that restrict user to pass extra key-value pair arguments,
adding **kwargs paramter can avoid that situation happen again.

All tests are done, 4 related with pysvn has error.

Summary Author
add **kwargs parameter to creat function in test case.
cathyQinQin
Add docs for Args for **kwargs
cathyQinQin
Description From Last Updated

Looks good! One thing that's important for any new code though is documentation updates. Every method that gained **kwargs should ...

chipx86chipx86

Typo in the summary: "creat" should be "create".

chipx86chipx86

A few issues in the review request description: The description needs to wrap at 79 characters. Any bits of code ...

chipx86chipx86

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot
chipx86
  1. 
      
  2. Looks good! One thing that's important for any new code though is documentation updates. Every method that gained **kwargs should have it added to the Args: part of the docs.

    There are some older methods that don't have Args:, and you can ignore those.

    Look at existing methods with **kwargs for some text you can probably copy/paste.

  3. Typo in the summary: "creat" should be "create".

  4. A few issues in the review request description:

    1. The description needs to wrap at 79 characters.
    2. Any bits of code needs to be wrapped in backticks, to turn it into a code literal (like foo). This is especially important for **kwargs, because ** in Markdown is bold. You'll see how that broke rendering in your description.
  5. 
      
cathyqinqin
Review request changed

Summary:

-Add **kwargs parameter to creat function in test case.
+Add **kwargs parameter to create function in test case.

Description:

~  

In test case, some create_*()function does not have kwargs parameter, and that restrict user to pass extra key-value pair arguments, adding kwargs paramter can avoid that situation happen again.

  ~

In test case, some create_*() functions does not have **kwargs parameter,

  + and that restrict user to pass extra key-value pair arguments,
  + adding **kwargs paramter can avoid that situation happen again.

Commits:

Summary Author
-
add **kwargs parameter to creat function in test case.
cathyQinQin
+
add **kwargs parameter to creat function in test case.
cathyQinQin
+
Add docs for Args for **kwargs
cathyQinQin

Diff:

Revision 2 (+80 -30)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

chipx86
  1. The new change looks good, but make sure you fix up those Review Bot complaints. We should be able to land this right after! :)

  2. 
      
Loading...