Add **kwargs parameter to create function in test case.

Review Request #11716 — Created July 11, 2021 and submitted

Information

Review Board
master

Reviewers

In test case, some create_*() functions does not have **kwargs parameter,
and that restrict user to pass extra key-value pair arguments,
adding **kwargs paramter can avoid that situation happen again.

All 5657 tests are done, only 1 test related with not install pysvn has error.

Summary ID Author
Add **kwargs parameter to creat function for test cases in tests.py.
Add docs for Args for **kwargs remove whitespace Remove extra whitespace in tests.py
05b7477ced1e2ec6d008b7e0fdee1df92e7c552a cathyQinQin
Description From Last Updated

A few issues in the review request description: The description needs to wrap at 79 characters. Any bits of code …

chipx86chipx86

Typo in the summary: "creat" should be "create".

chipx86chipx86

Looks good! One thing that's important for any new code though is documentation updates. Every method that gained **kwargs should …

chipx86chipx86

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot
chipx86
  1. 
      
  2. Show all issues

    A few issues in the review request description:

    1. The description needs to wrap at 79 characters.
    2. Any bits of code needs to be wrapped in backticks, to turn it into a code literal (like foo). This is especially important for **kwargs, because ** in Markdown is bold. You'll see how that broke rendering in your description.
  3. Show all issues

    Typo in the summary: "creat" should be "create".

  4. Show all issues

    Looks good! One thing that's important for any new code though is documentation updates. Every method that gained **kwargs should have it added to the Args: part of the docs.

    There are some older methods that don't have Args:, and you can ignore those.

    Look at existing methods with **kwargs for some text you can probably copy/paste.

  5. 
      
cathyqinqin
Review request changed
Summary:
Add **kwargs parameter to creat function in test case.
Add **kwargs parameter to create function in test case.
Description:
~  

In test case, some create_()function does not have kwargs parameter, and that restrict user to pass extra key-value pair arguments, adding *kwargs paramter can avoid that situation happen again.

  ~

In test case, some create_*() functions does not have **kwargs parameter,

  + and that restrict user to pass extra key-value pair arguments,
  + adding **kwargs paramter can avoid that situation happen again.

Commits:
Summary ID Author
add **kwargs parameter to creat function in test case.
5a5a9797164e8d3eaf7128f76450488f8c9d7d4a cathyQinQin
add **kwargs parameter to creat function in test case.
5a5a9797164e8d3eaf7128f76450488f8c9d7d4a cathyQinQin
Add docs for Args for **kwargs
0becf7052cdfa703e390e66cd6db68433c67109e cathyQinQin

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

chipx86
  1. The new change looks good, but make sure you fix up those Review Bot complaints. We should be able to land this right after! :)

  2. 
      
cathyqinqin
chipx86
  1. Ship It!
  2. 
      
cathyqinqin
Review request changed
Status:
Completed
Change Summary:
Pushed to release-4.0.x (ed193ed)