Fix filtering repositories in the New Review Request page.

Review Request #11674 — Created June 24, 2021 and submitted

chipx86
Review Board
release-4.0.x
reviewboard

Due to sidebar redesign work in Review Board 4.0, a CSS selector for the
search field in the New Review Request page was no longer correct,
preventing users from filtering the list of repositories.

This fixes up the selector, and adds unit tests so this can't regress
again.

Unit tests passed.

Manually tested filtering of repositories.

Summary
Fix filtering repositories in the New Review Request page.
Description From Last Updated

Col: 13 '$items' was used before it was defined.

reviewbotreviewbot

Col: 13 '$searchBox' was used before it was defined.

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

chipx86
david
  1. 
      
  2. Just a thought--it might be nicer to have a method which could take in an array of booleans and do the iteration inside, so then you could just have calls like checkVisibility([false, true, true true])

  3. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (9ed2229)
Loading...