Summary

Fix filtering repositories in the New Review Request page.

Review Request #11674 — Created June 24, 2021 and submitted June 25, 2021, 8:05 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Due to sidebar redesign work in Review Board 4.0, a CSS selector for the
search field in the New Review Request page was no longer correct,
preventing users from filtering the list of repositories.

This fixes up the selector, and adds unit tests so this can't regress
again.

Testing Done

Unit tests passed.

Manually tested filtering of repositories.

Commits

Summary	ID
Fix filtering repositories in the New Review Request page. Due to sidebar redesign work in Review Board 4.0, a CSS selector for the search field in the New Review Request page was no longer correct, preventing users from filtering the list of repositories. This fixes up the selector, and adds unit tests so this can't regress again.	9b5bcf0ca673e1a20fabe6d77d3916b0acff3540

Issues

Description	From	Last Updated
Col: 13 '$items' was used before it was defined.	reviewbot	June 24, 2021, 5:03 p.m.
Col: 13 '$searchBox' was used before it was defined.	reviewbot	June 24, 2021, 5:03 p.m.

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/newReviewRequest/views/tests/repositorySelectionViewTests.es6.js (Diff revision 1)

The issue has been resolved. Show all issues

Col: 13
 '$items' was used before it was defined.

reviewboard/static/rb/js/newReviewRequest/views/tests/repositorySelectionViewTests.es6.js (Diff revision 1)

The issue has been resolved. Show all issues

Col: 13
 '$searchBox' was used before it was defined.

Change Summary:

Moved some variables before functions that use them in order to satisfy Review Bot.

Commits:

	Summary	ID
	Fix filtering repositories in the New Review Request page. Due to sidebar redesign work in Review Board 4.0, a CSS selector for the search field in the New Review Request page was no longer correct, preventing users from filtering the list of repositories. This fixes up the selector, and adds unit tests so this can't regress again.	3f665fd7a2d00d6fc9fa7ffec2f19d43afb85a26
	Fix filtering repositories in the New Review Request page. Due to sidebar redesign work in Review Board 4.0, a CSS selector for the search field in the New Review Request page was no longer correct, preventing users from filtering the list of repositories. This fixes up the selector, and adds unit tests so this can't regress again.	9b5bcf0ca673e1a20fabe6d77d3916b0acff3540

Diff:

Revision 2 (+140 -12)

Show changes

	reviewboard/static/rb/js/newReviewRequest/views/repositorySelectionView.es6.js
	reviewboard/static/rb/js/newReviewRequest/views/tests/repositorySelectionViewTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

reviewboard/static/rb/js/newReviewRequest/views/tests/repositorySelectionViewTests.es6.js (Diff revision 2)

Just a thought--it might be nicer to have a method which could take in an array of booleans and do the iteration inside, so then you could just have calls like checkVisibility([false, true, true true])

Status:: Completed
Change Summary:: Pushed to release-4.0.x (9ed2229)