Summary

Add sorting to querystring parameters for consistent tests.

Review Request #11662 — Created June 19, 2021 and submitted June 28, 2021, 10:05 a.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Python 2.x and 3.x iterate dicts in different orders, which has

implications for assembling query strings. We have several tests which

spy on urlopen and return fake payloads, which were failing when run

on Python 3.
This change adds sorting to the querystring parameters before we

assemble them into a URL, and fixes up the test URLs to use those.

Testing Done

Ran unit tests on Python 2.7 and 3.9.

Commits

Summary	ID
Add sorting to querystring parameters for consistent tests. Python 2.x and 3.x iterate dicts in different orders, which has implications for assembling query strings. We have several tests which spy on `urlopen` and return fake payloads, which were failing when run on Python 3. This change adds sorting to the querystring parameters before we assemble them into a URL, and fixes up the test URLs to use those. Testing Done: Ran unit tests or Python 2.7 and 3.9.	2f11787d55976e6dfe325874574a6a51524e4122

Summary

Add sorting to querystring parameters for consistent tests.

Python 2.x and 3.x iterate dicts in different orders, which has implications for assembling query strings. We have several tests which spy on `urlopen` and return fake payloads, which were failing when run on Python 3. This change adds sorting to the querystring parameters before we assemble them into a URL, and fixes up the test URLs to use those. Testing Done: Ran unit tests or Python 2.7 and 3.9.

2f11787d55976e6dfe325874574a6a51524e4122

Issues

Description	From	Last Updated
E501 line too long (118 > 79 characters)	reviewbot	June 21, 2021, 10:17 a.m.

flake8 failed.

JSHint passed.

flake8

rbtools/utils/tests/test_repository.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (118 > 79 characters)
```

Commits:

	Summary	ID
	Add sorting to querystring parameters for consistent tests. Python 2.x and 3.x iterate dicts in different orders, which has implications for assembling query strings. We have several tests which spy on `urlopen` and return fake payloads, which were failing when run on Python 3. This change adds sorting to the querystring parameters before we assemble them into a URL, and fixes up the test URLs to use those. Testing Done: Ran unit tests or Python 2.7 and 3.9.	b49e7c88208b29f7cb3ea3f84facdd97c2693ed4
	Add sorting to querystring parameters for consistent tests. Python 2.x and 3.x iterate dicts in different orders, which has implications for assembling query strings. We have several tests which spy on `urlopen` and return fake payloads, which were failing when run on Python 3. This change adds sorting to the querystring parameters before we assemble them into a URL, and fixes up the test URLs to use those. Testing Done: Ran unit tests or Python 2.7 and 3.9.	2f11787d55976e6dfe325874574a6a51524e4122

Diff:

Revision 2 (+98 -74)

Show changes

	rbtools/api/request.py
	rbtools/clients/tests/test_svn.py
	rbtools/utils/tests/test_repository.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Testing Done:

~		Ran unit tests or Python 2.7 and 3.9.
	~	Ran unit tests on Python 2.7 and 3.9.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (96f1fde)