Fix reporting errors with wrong types passed to HostingServiceHTTPRequest.

Review Request #11644 — Created June 3, 2021 and submitted

Information

Review Board
release-4.0.x

Reviewers

HostingServiceHTTPRequest checks for the type on the body and
headers arguments during construction, logging and raising an
exception if types aren't correct.

This fails, since the logging code attempts to report information on the
request that isn't yet set at that point during construction.

To address this, we're now setting those attributes on the class before
we perform any type checking.

Unit tests pass.

Summary ID
Fix reporting errors with wrong types passed to HostingServiceHTTPRequest.
`HostingServiceHTTPRequest` checks for the type on the `body` and `headers` arguments during construction, logging and raising an exception if types aren't correct. This fails, since the logging code attempts to report information on the request that isn't yet set at that point during construction. To address this, we're now setting those attributes on the class before we perform any type checking.
b57e72b1655f3665c3e965da9ea3838c244d9d65
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-4.0.x (37f72df)