Summary

Fix reporting errors with wrong types passed to HostingServiceHTTPRequest.

Review Request #11644 — Created June 3, 2021 and submitted June 9, 2021, 1:04 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

4928

Depends On

Reviewers

Groups

reviewboard

People

Description

HostingServiceHTTPRequest checks for the type on the body and

headers arguments during construction, logging and raising an

exception if types aren't correct.
This fails, since the logging code attempts to report information on the

request that isn't yet set at that point during construction.
To address this, we're now setting those attributes on the class before

we perform any type checking.

Testing Done

Unit tests pass.

Commits

Summary	ID
Fix reporting errors with wrong types passed to HostingServiceHTTPRequest. `HostingServiceHTTPRequest` checks for the type on the `body` and `headers` arguments during construction, logging and raising an exception if types aren't correct. This fails, since the logging code attempts to report information on the request that isn't yet set at that point during construction. To address this, we're now setting those attributes on the class before we perform any type checking.	b57e72b1655f3665c3e965da9ea3838c244d9d65

Summary

Fix reporting errors with wrong types passed to HostingServiceHTTPRequest.

`HostingServiceHTTPRequest` checks for the type on the `body` and `headers` arguments during construction, logging and raising an exception if types aren't correct. This fails, since the logging code attempts to report information on the request that isn't yet set at that point during construction. To address this, we're now setting those attributes on the class before we perform any type checking.

b57e72b1655f3665c3e965da9ea3838c244d9d65

flake8 passed.

JSHint passed.

Change Summary:

Update unit tests to check the affected headers argument as well.

Description:

~		`HostingServiceHTTPRequest` checks for the type on the `body` argument
~		during construction, logging and raising an exception if it's anything
~		but `None` or a `bytes`.
	~	`HostingServiceHTTPRequest` checks for the type on the `body` and
	~	`headers` arguments during construction, logging and raising an
	~	exception if types aren't correct.

		This fails, since the logging code attempts to report information on the
		request that isn't yet set at that point during construction.

		To address this, we're now setting those attributes on the class before
		we perform any type checking.

Commits:

	Summary	ID
	Fix reporting errors with wrong types passed to HostingServiceHTTPRequest. `HostingServiceHTTPRequest` checks for the type on the `body` argument during construction, logging and raising an exception if it's anything but `None` or a `bytes`. This fails, since the logging code attempts to report information on the request that isn't yet set at that point during construction. To address this, we're now setting those attributes on the class before we perform any type checking.	9ca19b06f52e1a8269d867653ac2e5d2e048f7f3
	Fix reporting errors with wrong types passed to HostingServiceHTTPRequest. `HostingServiceHTTPRequest` checks for the type on the `body` and `headers` arguments during construction, logging and raising an exception if types aren't correct. This fails, since the logging code attempts to report information on the request that isn't yet set at that point during construction. To address this, we're now setting those attributes on the class before we perform any type checking.	b57e72b1655f3665c3e965da9ea3838c244d9d65

Diff:

Revision 2 (+140 -4)

Show changes

	reviewboard/hostingsvcs/service.py
	reviewboard/hostingsvcs/tests/test_client.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (37f72df)