Convert BaseResource.ensureCreated to return a promise.

 






 

 


  Review Request #11643
  —
  Created Oct. 4, 2021 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change updates the ensureCreated method to use promises and

async/await instead of callbacks.

 








  


 
 

  
    

  • Ran js-tests.
    • 

  • Manually tested a random smattering of UI that might have been
    
  affected.
    • 


 







 









 





  








 




 







   

    
    
Diff Revision 3


This is not the most recent revision of the diff. The latest diff is revision 4. See what's changed.

    

 

 

 

 
orig
1
2
3
4

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Convert BaseResource.ensureCreated to return a promise.
     
This change updates the `ensureCreated` method to use promises and
async/await instead of callbacks.

Testing Done:
- Ran js-tests.
- Manually tested a random smattering of UI that might have been
  affected.

    

   
  		
  24257a927ad591ad0c0ed203ddc8a6e201b95d5e
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/models/reviewRequestEditorModel.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/resources/models/baseResourceModel.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/resources/models/draftResourceChildModelMixin.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/resources/models/tests/draftReviewRequestModelTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviewRequestPage/models/tests/reviewReplyEditorModelTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewReplyDraftBannerViewTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.es6.js
     
    

   
  

 










     

    

   

  

  

   
   Loading...