flake8
passed.
JSHint
failed.
JSHint
-
reviewboard/static/rb/js/resources/models/draftResourceChildModelMixin.es6.js (Diff revision 1) Show all issues
Convert BaseResource.ensureCreated to return a promise.
Review Request #11643 — Created Oct. 4, 2021 and submitted
| Information | |
|---|---|
| david | |
| Review Board | |
| master | |
| Reviewers | |
| reviewboard | |
This change updates the
ensureCreatedmethod to use promises and
async/await instead of callbacks.
- Ran js-tests.
- Manually tested a random smattering of UI that might have been
affected.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+338 -336) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
reviewboard/static/rb/js/models/reviewRequestEditorModel.es6.js (Diff revision 2) Looks like we're no longer calling
this.trigger('published').
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+340 -336) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+320 -344) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.