Summary

Convert BaseResource.ensureCreated to return a promise.

Review Request #11643 — Created Oct. 4, 2021 and submitted Dec. 3, 2021, 3:48 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change updates the ensureCreated method to use promises and
async/await instead of callbacks.

Testing Done


Ran js-tests.
Manually tested a random smattering of UI that might have been

  affected.

Commits

Summary	ID
Convert BaseResource.ensureCreated to return a promise. This change updates the `ensureCreated` method to use promises and async/await instead of callbacks. Testing Done: - Ran js-tests. - Manually tested a random smattering of UI that might have been affected.	010ca0a3bbb81d2fe4e3b786eb3c43580e249c07

Issues

Description	From	Last Updated
Col: 56 Missing semicolon.	reviewbot	Oct. 4, 2021, 10:23 a.m.
Looks like we're no longer calling this.trigger('published').	chipx86	Oct. 14, 2021, 10:28 a.m.

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/resources/models/draftResourceChildModelMixin.es6.js (Diff revision 1)
Show all issues
```
Col: 56
 Missing semicolon.
```

Commits:

	Summary	ID
	Convert BaseResource.ensureCreated to return a promise. This change updates the `ensureCreated` method to use promises and async/await instead of callbacks. Testing Done: - Ran js-tests. - Manually tested a random smattering of UI that might have been affected.	e2b6bcd6c6299db46f781fa7e0b5a3a0da207f41
	Convert BaseResource.ensureCreated to return a promise. This change updates the `ensureCreated` method to use promises and async/await instead of callbacks. Testing Done: - Ran js-tests. - Manually tested a random smattering of UI that might have been affected.	9672db1495f7d9b858dbd2c68c8b44dd22d32b0c

Diff:

Revision 2 (+338 -336)

Show changes

	reviewboard/static/rb/js/models/reviewRequestEditorModel.es6.js
	reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.es6.js
	reviewboard/static/rb/js/resources/models/baseResourceModel.es6.js
	reviewboard/static/rb/js/resources/models/draftResourceChildModelMixin.es6.js
	reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.es6.js
	reviewboard/static/rb/js/resources/models/tests/draftReviewRequestModelTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/models/tests/reviewReplyEditorModelTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewReplyDraftBannerViewTests.es6.js
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/models/reviewRequestEditorModel.es6.js (Diff revision 2)
Show all issues
```
Looks like we're no longer calling this.trigger('published').
```

Commits:

	Summary	ID
	Convert BaseResource.ensureCreated to return a promise. This change updates the `ensureCreated` method to use promises and async/await instead of callbacks. Testing Done: - Ran js-tests. - Manually tested a random smattering of UI that might have been affected.	9672db1495f7d9b858dbd2c68c8b44dd22d32b0c
	Convert BaseResource.ensureCreated to return a promise. This change updates the `ensureCreated` method to use promises and async/await instead of callbacks. Testing Done: - Ran js-tests. - Manually tested a random smattering of UI that might have been affected.	24257a927ad591ad0c0ed203ddc8a6e201b95d5e

Diff:

Revision 3 (+340 -336)

Show changes

	reviewboard/static/rb/js/models/reviewRequestEditorModel.es6.js
	reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.es6.js
	reviewboard/static/rb/js/resources/models/baseResourceModel.es6.js
	reviewboard/static/rb/js/resources/models/draftResourceChildModelMixin.es6.js
	reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.es6.js
	reviewboard/static/rb/js/resources/models/tests/draftReviewRequestModelTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/models/tests/reviewReplyEditorModelTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewReplyDraftBannerViewTests.es6.js
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary	ID
	Convert BaseResource.ensureCreated to return a promise. This change updates the `ensureCreated` method to use promises and async/await instead of callbacks. Testing Done: - Ran js-tests. - Manually tested a random smattering of UI that might have been affected.	24257a927ad591ad0c0ed203ddc8a6e201b95d5e
	Convert BaseResource.ensureCreated to return a promise. This change updates the `ensureCreated` method to use promises and async/await instead of callbacks. Testing Done: - Ran js-tests. - Manually tested a random smattering of UI that might have been affected.	010ca0a3bbb81d2fe4e3b786eb3c43580e249c07

Diff:

Revision 4 (+320 -344)

Show changes

	reviewboard/static/rb/js/models/reviewRequestEditorModel.es6.js
	reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.es6.js
	reviewboard/static/rb/js/resources/models/baseResourceModel.es6.js
	reviewboard/static/rb/js/resources/models/draftResourceChildModelMixin.es6.js
	reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.es6.js
	reviewboard/static/rb/js/resources/models/tests/draftReviewRequestModelTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/models/tests/reviewReplyEditorModelTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewReplyDraftBannerViewTests.es6.js
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (497d5b2)