Convert destroy operations to return promises.

 






 

 


  Review Request #11641
  —
  Created June 1, 2021 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change updates the destroy operations for various objects to use

promises and async/await, rather than relying on callbacks.

 








  


 
 

  
    

  • Ran js-tests.
    • 

  • Tested deleting comments, group memberships, and other affected
    
  objects.
    • 


 







 









 





  








 




 







   

    
    
Changes between revision 4 and 5



    

 

 

 

 
orig
1
2
3
4
5

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Convert destroy operations to return promises.
     
This change updates the destroy operations for various objects to use
promises and async/await, rather than relying on callbacks.

Testing Done:
- Ran js-tests.
- Tested deleting comments, group memberships, and other affected
  objects.

    

   
  		
  44402ad3d5beb008b59afd2a9ccbefeeec692273
  David Trowbridge
 


 
  
 
 
  
   
    

     Convert destroy operations to return promises.
     
This change updates the destroy operations for various objects to use
promises and async/await, rather than relying on callbacks.

Testing Done:
- Ran js-tests.
- Tested deleting comments, group memberships, and other affected
  objects.

    

   
  		
  6b593ed2b5f2f94f476483ee184e52009b788c0f
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js
     
    

   
  

 










     

    

   

  

  

   
   Loading...