flake8
passed.
JSHint
passed.
Review Request #11641 — Created June 1, 2021 and submitted
Information | |
---|---|
david | |
Review Board | |
master | |
Reviewers | |
reviewboard | |
This change updates the destroy operations for various objects to use
promises and async/await, rather than relying on callbacks.
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+588 -530) |
Use
expectAsync
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+574 -530) |
reviewboard/static/rb/js/models/tests/commentEditorModelTests.es6.js (Diff revision 3) |
---|
Think you can use
.and.resolveTo()
.
reviewboard/static/rb/js/resources/models/reviewGroupModel.es6.js (Diff revision 3) |
---|
Can/should we use the callback deprecation pattern here?
reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js (Diff revision 3) |
---|
Can we format this with
.destroy()
on the next line?this.model.get('reviewRequest') .destroy({ ... }) .then(...);
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+568 -530) |
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+572 -532) |