This change has been marked as completed.

Describe the completed change (optional):

Pushed to master (d12cc4e)

Summary

Convert destroy operations to return promises.

Review Request #11641 — Created June 1, 2021 and submitted 3 years, 5 months ago — Latest diff uploaded 3 years, 7 months ago

Owner

Repository

Review Board

Branch

master

Bugs

Depends On

Groups

People

Description*

This change updates the destroy operations for various objects to use
promises and async/await, rather than relying on callbacks.

Testing Done


Ran js-tests.
Tested deleting comments, group memberships, and other affected

  objects.

orig

	Summary	ID	Author
	Convert destroy operations to return promises. This change updates the destroy operations for various objects to use promises and async/await, rather than relying on callbacks. Testing Done: - Ran js-tests. - Tested deleting comments, group memberships, and other affected objects.	d7c940e8ef7e71f28cbb40273b6a5f029a8ad961	David Trowbridge
	Convert destroy operations to return promises. This change updates the destroy operations for various objects to use promises and async/await, rather than relying on callbacks. Testing Done: - Ran js-tests. - Tested deleting comments, group memberships, and other affected objects.	751cbfe8f8d9f3131755dd8416f9d22c9e7dbbc9	David Trowbridge

	reviewboard/static/rb/js/models/tests/commentEditorModelTests.es6.js
	reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.es6.js

reviewboard/static/rb/js/models/tests/commentEditorModelTests.es6.js

reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.es6.js