Convert destroy operations to return promises.
Review Request #11641 — Created June 1, 2021 and submitted — Latest diff uploaded
This change updates the destroy operations for various objects to use
promises and async/await, rather than relying on callbacks.
- Ran js-tests.
- Tested deleting comments, group memberships, and other affected
objects.
Diff Revision 2
This is not the most recent revision of the diff. The latest diff is revision 5. See what's changed.
orig
1
2
3
4
5
Commits
Files
| reviewboard/static/rb/js/models/commentEditorModel.es6.js |
|---|
| reviewboard/static/rb/js/models/userSessionModel.es6.js |
|---|
| reviewboard/static/rb/js/models/tests/commentEditorModelTests.es6.js |
|---|
| reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.es6.js |
|---|
| reviewboard/static/rb/js/resources/models/baseResourceModel.es6.js |
|---|
| reviewboard/static/rb/js/resources/models/draftResourceChildModelMixin.es6.js |
|---|
| reviewboard/static/rb/js/resources/models/draftResourceModelMixin.es6.js |
|---|
| reviewboard/static/rb/js/resources/models/reviewGroupModel.es6.js |
|---|
| reviewboard/static/rb/js/resources/models/reviewReplyModel.es6.js |
|---|
| reviewboard/static/rb/js/resources/models/tests/reviewGroupModelTests.es6.js |
|---|
| reviewboard/static/rb/js/resources/models/tests/reviewReplyModelTests.es6.js |
|---|
| reviewboard/static/rb/js/reviewRequestPage/models/reviewReplyEditorModel.es6.js |
|---|
| reviewboard/static/rb/js/reviewRequestPage/models/tests/reviewReplyEditorModelTests.es6.js |
|---|
| reviewboard/static/rb/js/views/reviewDialogView.es6.js |
|---|
| reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js |
|---|
| reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.es6.js |
|---|