Convert destroy operations to return promises.

Review Request #11641 — Created June 1, 2021 and submitted — Latest diff uploaded

Information

Review Board
master

Reviewers

This change updates the destroy operations for various objects to use
promises and async/await, rather than relying on callbacks.

  • Ran js-tests.
  • Tested deleting comments, group memberships, and other affected
    objects.

Changes between revision 1 and 2

orig
1
2
3
4
5

Commits

Summary ID Author
Convert destroy operations to return promises.
This change updates the destroy operations for various objects to use promises and async/await, rather than relying on callbacks. Testing Done: - Ran js-tests. - Tested deleting comments, group memberships, and other affected objects.
994f58d4771b893cf339afd4c2c6bd41997c6c9b David Trowbridge
Convert destroy operations to return promises.
This change updates the destroy operations for various objects to use promises and async/await, rather than relying on callbacks. Testing Done: - Ran js-tests. - Tested deleting comments, group memberships, and other affected objects.
d7c940e8ef7e71f28cbb40273b6a5f029a8ad961 David Trowbridge
reviewboard/static/rb/js/models/commentEditorModel.es6.js
reviewboard/static/rb/js/models/userSessionModel.es6.js
reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.es6.js
reviewboard/static/rb/js/resources/models/baseResourceModel.es6.js
reviewboard/static/rb/js/resources/models/draftResourceChildModelMixin.es6.js
reviewboard/static/rb/js/resources/models/draftResourceModelMixin.es6.js
reviewboard/static/rb/js/resources/models/reviewGroupModel.es6.js
reviewboard/static/rb/js/resources/models/reviewReplyModel.es6.js
reviewboard/static/rb/js/resources/models/tests/reviewGroupModelTests.es6.js
reviewboard/static/rb/js/resources/models/tests/reviewReplyModelTests.es6.js
reviewboard/static/rb/js/views/reviewDialogView.es6.js
Loading...