Summary

Convert destroy operations to return promises.

Review Request #11641 — Created June 1, 2021 and submitted Dec. 3, 2021, 3:48 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change updates the destroy operations for various objects to use
promises and async/await, rather than relying on callbacks.

Testing Done


Ran js-tests.
Tested deleting comments, group memberships, and other affected

  objects.

Commits

Summary	ID
Convert destroy operations to return promises. This change updates the destroy operations for various objects to use promises and async/await, rather than relying on callbacks. Testing Done: - Ran js-tests. - Tested deleting comments, group memberships, and other affected objects.	6b593ed2b5f2f94f476483ee184e52009b788c0f

Issues

Description	From	Last Updated
Think you can use .and.resolveTo().	chipx86	Oct. 18, 2021, 9:30 p.m.
Can/should we use the callback deprecation pattern here?	chipx86	Oct. 18, 2021, 9:32 p.m.
Can we format this with .destroy() on the next line? this.model.get('reviewRequest') .destroy({ ... }) .then(...);	chipx86	Oct. 18, 2021, 9:32 p.m.

flake8 passed.

JSHint passed.

Commits:

	Summary	ID
	Convert destroy operations to return promises. This change updates the destroy operations for various objects to use promises and async/await, rather than relying on callbacks. Testing Done: - Ran js-tests. - Tested deleting comments, group memberships, and other affected objects.	994f58d4771b893cf339afd4c2c6bd41997c6c9b
	Convert destroy operations to return promises. This change updates the destroy operations for various objects to use promises and async/await, rather than relying on callbacks. Testing Done: - Ran js-tests. - Tested deleting comments, group memberships, and other affected objects.	d7c940e8ef7e71f28cbb40273b6a5f029a8ad961

Diff:

Revision 2 (+588 -530)

Show changes

	reviewboard/static/rb/js/models/commentEditorModel.es6.js
	reviewboard/static/rb/js/models/userSessionModel.es6.js
	reviewboard/static/rb/js/models/tests/commentEditorModelTests.es6.js
	reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.es6.js
	reviewboard/static/rb/js/resources/models/baseResourceModel.es6.js
	reviewboard/static/rb/js/resources/models/draftResourceChildModelMixin.es6.js
	reviewboard/static/rb/js/resources/models/draftResourceModelMixin.es6.js
	reviewboard/static/rb/js/resources/models/reviewGroupModel.es6.js
	8 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Use expectAsync

Commits:

	Summary	ID
	Convert destroy operations to return promises. This change updates the destroy operations for various objects to use promises and async/await, rather than relying on callbacks. Testing Done: - Ran js-tests. - Tested deleting comments, group memberships, and other affected objects.	d7c940e8ef7e71f28cbb40273b6a5f029a8ad961
	Convert destroy operations to return promises. This change updates the destroy operations for various objects to use promises and async/await, rather than relying on callbacks. Testing Done: - Ran js-tests. - Tested deleting comments, group memberships, and other affected objects.	751cbfe8f8d9f3131755dd8416f9d22c9e7dbbc9

Diff:

Revision 3 (+574 -530)

Show changes

	reviewboard/static/rb/js/models/commentEditorModel.es6.js
	reviewboard/static/rb/js/models/userSessionModel.es6.js
	reviewboard/static/rb/js/models/tests/commentEditorModelTests.es6.js
	reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.es6.js
	reviewboard/static/rb/js/resources/models/baseResourceModel.es6.js
	reviewboard/static/rb/js/resources/models/draftResourceChildModelMixin.es6.js
	reviewboard/static/rb/js/resources/models/draftResourceModelMixin.es6.js
	reviewboard/static/rb/js/resources/models/reviewGroupModel.es6.js
	8 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/models/tests/commentEditorModelTests.es6.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Think you can use .and.resolveTo().
```

reviewboard/static/rb/js/resources/models/reviewGroupModel.es6.js (Diff revision 3)

The issue has been dropped. Show all issues

Can/should we use the callback deprecation pattern here?

david Oct. 18, 2021, 9:32 p.m.
```
These are updated in a later change.
```

reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js (Diff revision 3)

The issue has been resolved. Show all issues

Can we format this with .destroy() on the next line?

this.model.get('reviewRequest')
    .destroy({
        ...
    })
    .then(...);

Commits:

	Summary	ID
	Convert destroy operations to return promises. This change updates the destroy operations for various objects to use promises and async/await, rather than relying on callbacks. Testing Done: - Ran js-tests. - Tested deleting comments, group memberships, and other affected objects.	751cbfe8f8d9f3131755dd8416f9d22c9e7dbbc9
	Convert destroy operations to return promises. This change updates the destroy operations for various objects to use promises and async/await, rather than relying on callbacks. Testing Done: - Ran js-tests. - Tested deleting comments, group memberships, and other affected objects.	44402ad3d5beb008b59afd2a9ccbefeeec692273

Diff:

Revision 4 (+568 -530)

Show changes

	reviewboard/static/rb/js/models/commentEditorModel.es6.js
	reviewboard/static/rb/js/models/userSessionModel.es6.js
	reviewboard/static/rb/js/models/tests/commentEditorModelTests.es6.js
	reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.es6.js
	reviewboard/static/rb/js/resources/models/baseResourceModel.es6.js
	reviewboard/static/rb/js/resources/models/draftResourceChildModelMixin.es6.js
	reviewboard/static/rb/js/resources/models/draftResourceModelMixin.es6.js
	reviewboard/static/rb/js/resources/models/reviewGroupModel.es6.js
	8 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary	ID
	Convert destroy operations to return promises. This change updates the destroy operations for various objects to use promises and async/await, rather than relying on callbacks. Testing Done: - Ran js-tests. - Tested deleting comments, group memberships, and other affected objects.	44402ad3d5beb008b59afd2a9ccbefeeec692273
	Convert destroy operations to return promises. This change updates the destroy operations for various objects to use promises and async/await, rather than relying on callbacks. Testing Done: - Ran js-tests. - Tested deleting comments, group memberships, and other affected objects.	6b593ed2b5f2f94f476483ee184e52009b788c0f

Diff:

Revision 5 (+572 -532)

Show changes

	reviewboard/static/rb/js/models/commentEditorModel.es6.js
	reviewboard/static/rb/js/models/userSessionModel.es6.js
	reviewboard/static/rb/js/models/tests/commentEditorModelTests.es6.js
	reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.es6.js
	reviewboard/static/rb/js/resources/models/baseResourceModel.es6.js
	reviewboard/static/rb/js/resources/models/draftResourceChildModelMixin.es6.js
	reviewboard/static/rb/js/resources/models/draftResourceModelMixin.es6.js
	reviewboard/static/rb/js/resources/models/reviewGroupModel.es6.js
	8 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (d12cc4e)