This change has been marked as completed.

Describe the completed change (optional):

Pushed to master (afcbe42)

Summary

Convert diff fragment fetching to use promises.

Review Request #11640 — Created June 1, 2021 and submitted 3 years, 5 months ago — Latest diff uploaded 3 years, 6 months ago

Owner

Repository

Review Board

Branch

master

Bugs

Depends On

Groups

People

Description*

This change updates the diff fragment mechanism to use promises rather
than callbacks.

Testing Done


Ran js-tests.
Loaded diffs and interdiffs.
Loaded diff fragments in comments.

orig

	Summary	ID	Author
	Convert diff fragment fetching to use promises. This change updates the diff fragment mechanism to use promises rather than callbacks. Testing Done: - Ran js-tests. - Loaded diffs and interdiffs. - Loaded diff fragments in comments.	7dd4b1ddfaebc7ce536dba38d2ed340dad9965d5	David Trowbridge
	Convert diff fragment fetching to use promises. This change updates the diff fragment mechanism to use promises rather than callbacks. Testing Done: - Ran js-tests. - Loaded diffs and interdiffs. - Loaded diff fragments in comments.	a925038531efb79ac6a966afbb924d5ea754300f	David Trowbridge

reviewboard/static/rb/js/diffviewer/views/tests/diffReviewableViewTests.es6.js