Summary:

Convert diff fragment fetching to use promises.

Review Request #11640 — Created June 1, 2021 and submitted Dec. 3, 2021, 3:48 p.m.

Description

This change updates the diff fragment mechanism to use promises rather
than callbacks.

Testing Done


Ran js-tests.
Loaded diffs and interdiffs.
Loaded diff fragments in comments.

Commits

Summary
	Convert diff fragment fetching to use promises.

Screenshots

Issues

Description	From	Last Updated
Col: 23 Missing semicolon.	reviewbot	June 1, 2021, 3:07 p.m.
Think this can be .and.resolveTo('abc').	chipx86	Oct. 18, 2021, 10:06 p.m.

flake8 passed.

JSHint failed.

	Summary
-		Convert diff fragment fetching to use promises.
+		Convert diff fragment fetching to use promises.

Revision 2 (+972 -730)

	reviewboard/static/rb/js/diffviewer/models/diffReviewableModel.es6.js
	reviewboard/static/rb/js/diffviewer/models/tests/diffReviewableModelTests.es6.js
	reviewboard/static/rb/js/diffviewer/views/diffReviewableView.es6.js
	reviewboard/static/rb/js/diffviewer/views/tests/diffReviewableViewTests.es6.js
	reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js

flake8 passed.

JSHint passed.

	Summary
-		Convert diff fragment fetching to use promises.
+		Convert diff fragment fetching to use promises.

Revision 3 (+972 -730)

	reviewboard/static/rb/js/diffviewer/models/diffReviewableModel.es6.js
	reviewboard/static/rb/js/diffviewer/models/tests/diffReviewableModelTests.es6.js
	reviewboard/static/rb/js/diffviewer/views/diffReviewableView.es6.js
	reviewboard/static/rb/js/diffviewer/views/tests/diffReviewableViewTests.es6.js
	reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js

flake8 passed.

JSHint passed.

Ship it!

Pushed to master (afcbe42)