Convert diff fragment fetching to use promises.

Review Request #11640 — Created June 1, 2021 and submitted — Latest diff uploaded

Information

Review Board
master

Reviewers

This change updates the diff fragment mechanism to use promises rather
than callbacks.

  • Ran js-tests.
  • Loaded diffs and interdiffs.
  • Loaded diff fragments in comments.

Diff Revision 2

This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.

orig
1
2
3

Commits

First Last Summary ID Author
Convert diff fragment fetching to use promises.
This change updates the diff fragment mechanism to use promises rather than callbacks. Testing Done: - Ran js-tests. - Loaded diffs and interdiffs. - Loaded diff fragments in comments.
7dd4b1ddfaebc7ce536dba38d2ed340dad9965d5 David Trowbridge
reviewboard/static/rb/js/diffviewer/models/diffReviewableModel.es6.js
reviewboard/static/rb/js/diffviewer/models/tests/diffReviewableModelTests.es6.js
reviewboard/static/rb/js/diffviewer/views/diffReviewableView.es6.js
reviewboard/static/rb/js/diffviewer/views/tests/diffReviewableViewTests.es6.js
reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js
Loading...