Summary

Convert diff fragment fetching to use promises.

Review Request #11640 — Created June 1, 2021 and submitted Dec. 3, 2021, 11:48 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change updates the diff fragment mechanism to use promises rather
than callbacks.

Testing Done


Ran js-tests.
Loaded diffs and interdiffs.
Loaded diff fragments in comments.

Commits

Summary	ID
Convert diff fragment fetching to use promises. This change updates the diff fragment mechanism to use promises rather than callbacks. Testing Done: - Ran js-tests. - Loaded diffs and interdiffs. - Loaded diff fragments in comments.	a925038531efb79ac6a966afbb924d5ea754300f

Issues

Description	From	Last Updated
Col: 23 Missing semicolon.	reviewbot	June 1, 2021, 10:07 p.m.
Think this can be .and.resolveTo('abc').	chipx86	Oct. 19, 2021, 5:06 a.m.

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/diffviewer/views/tests/diffReviewableViewTests.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 23
 Missing semicolon.
```

Commits:

	Summary	ID
	Convert diff fragment fetching to use promises. This change updates the diff fragment mechanism to use promises rather than callbacks. Testing Done: - Ran js-tests. - Loaded diffs and interdiffs. - Loaded diff fragments in comments.	46015d21014f76ef497c191b5a1ba66d9151ac39
	Convert diff fragment fetching to use promises. This change updates the diff fragment mechanism to use promises rather than callbacks. Testing Done: - Ran js-tests. - Loaded diffs and interdiffs. - Loaded diff fragments in comments.	7dd4b1ddfaebc7ce536dba38d2ed340dad9965d5

Diff:

Revision 2 (+972 -730)

Show changes

	reviewboard/static/rb/js/diffviewer/models/diffReviewableModel.es6.js
	reviewboard/static/rb/js/diffviewer/models/tests/diffReviewableModelTests.es6.js
	reviewboard/static/rb/js/diffviewer/views/diffReviewableView.es6.js
	reviewboard/static/rb/js/diffviewer/views/tests/diffReviewableViewTests.es6.js
	reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/diffviewer/views/tests/diffReviewableViewTests.es6.js (Diff revision 2)

The issue has been resolved. Show all issues

Think this can be .and.resolveTo('abc').

Commits:

	Summary	ID
	Convert diff fragment fetching to use promises. This change updates the diff fragment mechanism to use promises rather than callbacks. Testing Done: - Ran js-tests. - Loaded diffs and interdiffs. - Loaded diff fragments in comments.	7dd4b1ddfaebc7ce536dba38d2ed340dad9965d5
	Convert diff fragment fetching to use promises. This change updates the diff fragment mechanism to use promises rather than callbacks. Testing Done: - Ran js-tests. - Loaded diffs and interdiffs. - Loaded diff fragments in comments.	a925038531efb79ac6a966afbb924d5ea754300f

Diff:

Revision 3 (+972 -730)

Show changes

	reviewboard/static/rb/js/diffviewer/models/diffReviewableModel.es6.js
	reviewboard/static/rb/js/diffviewer/models/tests/diffReviewableModelTests.es6.js
	reviewboard/static/rb/js/diffviewer/views/diffReviewableView.es6.js
	reviewboard/static/rb/js/diffviewer/views/tests/diffReviewableViewTests.es6.js
	reviewboard/static/rb/js/pages/views/diffViewerPageView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (afcbe42)