• 
      

    Clean up some of the extension hook unit tests and standardize setup.

    Review Request #11638 — Created May 30, 2021 and submitted

    Information

    Review Board
    release-3.0.x

    Reviewers

    This change simplifies some of the extension hook test setup code,
    preparing for new hooks and unit tests. There's a new
    BaseExtensionHookTestCase and ExtensionHookTestCaseMixin that
    handles the main setup and teardown code for a test. This builds upon
    the Djblets extension testing code, meaning we get all the benefits of
    standardized and consistent extension management without ever having to
    have tests specialize any of this.

    There are some other small cleanups throughout for docstrings, or a little
    bit of code or function names here and there. It's not a full revamp of
    the code, just some tidying up.

    Unit tests passed.

    Summary ID
    Clean up some of the extension hook unit tests and standardize setup.
    This change simplifies some of the extension hook test setup code, preparing for new hooks and unit tests. There's a new `BaseExtensionHookTestCase` and `ExtensionHookTestCaseMixin` that handles the main setup and teardown code for a test. This builds upon the Djblets extension testing code, meaning we get all the benefits of standardized and consistent extension management without ever having to have tests specialize any of this. There are some other small cleanups throughout for docstrings, or a little bit of code or function names here and there. It's not a full revamp of the code, just some tidying up.
    752abb4d1c8165e2847c5adf64b4d1d0a9967e7b
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.0.x (5279858)