• 
  
    
 
    
 
    

    



    
    
    
    
     
    




    
 
    

  
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Split reviewboard.extensions.tests into multiple test modules.
    
 
    

    



 
    
 
    

  Review Request #11637
  —
  Created May 29, 2021 and submitted 

 
    


    




    




    






 
    
  
    
   Information

  
    



    
 
 
    
  chipx86
 
    

    





    
 
 
    
  Review Board
 
    

    





    
 
 
    
  release-3.0.x
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  reviewboard
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    This test suite had grown too big to manage, and a lot of the testing
    
patterns being used are far from ideal. With more work on the horizon,
    
we want to split this up and make it easier to maintain a test suite.
    

    This change simply splits the tests.py into a series of test_*.py
    
files. No logic or documentation has been changed, though module-level
    
docstrings were added. Cleanup would happen in another change.
    
 
    

    





  

    
 
 
    
  
    Unit tests passed.
    
 
    

    




 
    

    





    
 
    




  
    
 
 
    
  


    
 
    
  
   
    

    Summary
    ID

   
    
      
  

   
    

    

     
    
      Split reviewboard.extensions.tests into multiple test modules.
      
    This test suite had grown too big to manage, and a lot of the testing
patterns being used are far from ideal. With more work on the horizon,
we want to split this up and make it easier to maintain a test suite.

This change simply splits the `tests.py` into a series of `test_*.py`
files. No logic or documentation has been changed. That would come in a
future change.
    
     
    

        		
    f90130f52c154fbbfa12e7c8dccb5d4c12c71fcb

   
    


      
 
    

    
    
 
    

    






 





    
 
 
 
    
  
    
   
    
    
    
     
    
    
    
      
     
    • 
      
     
      • 
     
    • 
      
     
      • 
     
    • 
      
     
      • 
     
    • 
      
     
      • 
     
    • 
      
     
      • 
    
    
   
    
   
    
    
     
    
      Description
      From
      Last Updated
     
    
        
    



     
    
      
       
       
    E501 line too long (81 > 79 characters)
    
          		
      


reviewbot

  reviewbot
 

      
      
       
      
     
    



     
    
      
       
       
    E501 line too long (81 > 79 characters)
    
          		
      


reviewbot

  reviewbot
 

      
      
       
      
     
    



     
    
      
       
       
    W391 blank line at end of file
    
          		
      


reviewbot

  reviewbot
 

      
      
       
      
     
    

        
   
    
  
    
 
    

    




 
    

    



  
    
 
    

    


    












    
 




 
    
  
    

   
    

   
    

    
    

Checks run (1 failed, 1 succeeded)

    
    
    
    
     


      


     
    
    
   
    


  
    
  
    
  
    


    

 
    
 flake8
 failed.
 


    


 
    
 JSHint
 passed.
 


    



    





    
 
    flake8
    
 
    

 

    








  
    
 
    

    


 













    
 





 
    
  
    
   
    



david




   
    
   
    





    
  
    
 
    


 
    
  
    

   
    

   
    

    
    





  david
 


    
    
    
    
     


      


     
    
    
   
    


  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      Ship It!
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 















    2. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 


    

  
    
 
    

    












    
 



 
    
  
    
   
    



chipx86




   
    
   
    
  
    
 
    


 
    
  
    

   
    

   
    

    
    
Review request changed
    
    
    
    
     


      


     
    
    
   
    


  
    
  
    
  
    




    

  
    
   
    
    Status:
   
    
   
    

    Completed

   
    
  
    



  
    
   
    
    Change Summary:
   
    
   
    
    
    Pushed to release-3.0.x (bd54043)