Convert close and reopen operations to return a promise.

Review Request #11636 — Created May 28, 2021 and submitted — Latest diff uploaded

Information

Review Board
master

Reviewers

This change updates the review request close and reopen operations to
use promises instead of callbacks.

  • Ran js-tests.
  • Manually tested review request close and reopen.

Diff Revision 3

This is not the most recent revision of the diff. The latest diff is revision 5. See what's changed.

orig
1
2
3
4
5

Commits

First Last Summary ID Author
Convert close and reopen operations to return a promise.
This change updates the review request close and reopen operations to use promises instead of callbacks. Testing Done: - Ran js-tests. - Manually tested review request close and reopen.
096e4e7edfefded7b1f1fb9abc45f2174c4e8723 David Trowbridge
reviewboard/static/rb/js/resources/models/reviewRequestModel.es6.js
reviewboard/static/rb/js/resources/models/tests/reviewRequestModelTests.es6.js
reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js
reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js
reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.es6.js
Loading...