flake8
passed.
JSHint
passed.
Convert close and reopen operations to return a promise.
Review Request #11636 — Created May 28, 2021 and submitted
| Information | |
|---|---|
| david | |
| Review Board | |
| master | |
| Reviewers | |
| reviewboard | |
This change updates the review request close and reopen operations to
use promises instead of callbacks.
- Ran js-tests.
- Manually tested review request close and reopen.
Description: |
|
||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commits: |
|
||||||||||||||||||
Diff: |
Revision 2 (+434 -232) |
||||||||||||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Change Summary:
Use
expectAsync
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+416 -232) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.es6.js (Diff revision 3) Think we can do
.and.resolveTo().
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+412 -232) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js (Diff revision 4) The chaining would look a bit more natural (and consistent) with:
this.reviewRequest .close({ ... }) .catch(...); -
-
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+424 -238) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.