Summary

Convert close and reopen operations to return a promise.

Review Request #11636 — Created May 28, 2021 and submitted Dec. 3, 2021, 3:48 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change updates the review request close and reopen operations to
use promises instead of callbacks.

Testing Done


Ran js-tests.
Manually tested review request close and reopen.

Commits

Summary	ID
Convert close and reopen operations to return a promise. This change updates the review request close and reopen operations to use promises instead of callbacks. Testing Done: - Ran js-tests. - Manually tested review request close and reopen.	1de4662ef5e1cacd9f2d6977253ef60b1ca5a767

Issues

Description	From	Last Updated
Think we can do .and.resolveTo().	chipx86	Oct. 18, 2021, 3:34 p.m.
The chaining would look a bit more natural (and consistent) with: this.reviewRequest .close({ ... }) .catch(...);	chipx86	Dec. 3, 2021, 2:52 p.m.
Same note as above.	chipx86	Dec. 3, 2021, 2:52 p.m.
Same note as above.	chipx86	Dec. 3, 2021, 2:52 p.m.

flake8 passed.

JSHint passed.

Description:

		This change updates the review request close and reopen operations to
		use promises instead of callbacks.
	+
	+	Testing Done:
	+	- Ran js-tests.
	+	- Manually tested review request close and reopen.

Commits:

	Summary	ID
	Convert close and reopen operations to return a promise. This change updates the review request close and reopen operations to use promises instead of callbacks. Testing Done: - Ran js-tests. - Manually tested review request close and reopen.	5fdd8343c9effb18f6f75e8ae147529daa9e1e1b
	Convert close and reopen operations to return a promise. This change updates the review request close and reopen operations to use promises instead of callbacks. Testing Done: - Ran js-tests. - Manually tested review request close and reopen.	b45a38fb884fb4a180806456f9c3fdadeecd5916

Diff:

Revision 2 (+434 -232)

Show changes

	reviewboard/static/rb/js/resources/models/reviewRequestModel.es6.js
	reviewboard/static/rb/js/resources/models/tests/reviewRequestModelTests.es6.js
	reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js
	reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js
	reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Description:

		This change updates the review request close and reopen operations to
		use promises instead of callbacks.
-
-		Testing Done:
-		- Ran js-tests.
-		- Manually tested review request close and reopen.

Change Summary:

Use expectAsync

Commits:

	Summary	ID
	Convert close and reopen operations to return a promise. This change updates the review request close and reopen operations to use promises instead of callbacks. Testing Done: - Ran js-tests. - Manually tested review request close and reopen.	b45a38fb884fb4a180806456f9c3fdadeecd5916
	Convert close and reopen operations to return a promise. This change updates the review request close and reopen operations to use promises instead of callbacks. Testing Done: - Ran js-tests. - Manually tested review request close and reopen.	096e4e7edfefded7b1f1fb9abc45f2174c4e8723

Diff:

Revision 3 (+416 -232)

Show changes

	reviewboard/static/rb/js/resources/models/reviewRequestModel.es6.js
	reviewboard/static/rb/js/resources/models/tests/reviewRequestModelTests.es6.js
	reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js
	reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js
	reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.es6.js (Diff revision 3)
The issue has been resolved. Show all issues
```
Think we can do .and.resolveTo().
```

Commits:

	Summary	ID
	Convert close and reopen operations to return a promise. This change updates the review request close and reopen operations to use promises instead of callbacks. Testing Done: - Ran js-tests. - Manually tested review request close and reopen.	096e4e7edfefded7b1f1fb9abc45f2174c4e8723
	Convert close and reopen operations to return a promise. This change updates the review request close and reopen operations to use promises instead of callbacks. Testing Done: - Ran js-tests. - Manually tested review request close and reopen.	3b07ed046e1154f1881d8bf9a41b4221e5e918a5

Diff:

Revision 4 (+412 -232)

Show changes

	reviewboard/static/rb/js/resources/models/reviewRequestModel.es6.js
	reviewboard/static/rb/js/resources/models/tests/reviewRequestModelTests.es6.js
	reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js
	reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js
	reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js (Diff revision 4)

The issue has been resolved. Show all issues

The chaining would look a bit more natural (and consistent) with:

this.reviewRequest
    .close({
        ...
    })
    .catch(...);

reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js (Diff revision 4)
The issue has been resolved. Show all issues
```
Same note as above.
```
reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js (Diff revision 4)
The issue has been resolved. Show all issues
```
Same note as above.
```

Commits:

	Summary	ID
	Convert close and reopen operations to return a promise. This change updates the review request close and reopen operations to use promises instead of callbacks. Testing Done: - Ran js-tests. - Manually tested review request close and reopen.	3b07ed046e1154f1881d8bf9a41b4221e5e918a5
	Convert close and reopen operations to return a promise. This change updates the review request close and reopen operations to use promises instead of callbacks. Testing Done: - Ran js-tests. - Manually tested review request close and reopen.	1de4662ef5e1cacd9f2d6977253ef60b1ca5a767

Diff:

Revision 5 (+424 -238)

Show changes

	reviewboard/static/rb/js/resources/models/reviewRequestModel.es6.js
	reviewboard/static/rb/js/resources/models/tests/reviewRequestModelTests.es6.js
	reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js
	reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js
	reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (967118c)