Convert close and reopen operations to return a promise.

Review Request #11636 — Created May 28, 2021 and submitted

Information

Review Board
master

Reviewers

This change updates the review request close and reopen operations to
use promises instead of callbacks.

  • Ran js-tests.
  • Manually tested review request close and reopen.
Summary ID
Convert close and reopen operations to return a promise.
This change updates the review request close and reopen operations to use promises instead of callbacks. Testing Done: - Ran js-tests. - Manually tested review request close and reopen.
1de4662ef5e1cacd9f2d6977253ef60b1ca5a767
Description From Last Updated

Think we can do .and.resolveTo().

chipx86chipx86

The chaining would look a bit more natural (and consistent) with: this.reviewRequest .close({ ... }) .catch(...);

chipx86chipx86

Same note as above.

chipx86chipx86

Same note as above.

chipx86chipx86
david
david
david
chipx86
  1. 
      
  2. Think we can do .and.resolveTo().

  3. 
      
david
chipx86
  1. 
      
  2. The chaining would look a bit more natural (and consistent) with:

    this.reviewRequest
        .close({
            ...
        })
        .catch(...);
    
  3. Same note as above.

  4. Same note as above.

  5. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (967118c)
Loading...