Convert close and reopen operations to return a promise.

 






 

 


  Review Request #11636
  —
  Created May 28, 2021 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change updates the review request close and reopen operations to

use promises instead of callbacks.

 








  


 
 

  
    

  • Ran js-tests.
    • 

  • Manually tested review request close and reopen.
    • 


 







 









 





  








 




 







   

    
    
Changes between revision 2 and 3



    

 

 

 

 
orig
1
2
3
4
5

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Convert close and reopen operations to return a promise.
     
This change updates the review request close and reopen operations to
use promises instead of callbacks.

Testing Done:
- Ran js-tests.
- Manually tested review request close and reopen.

    

   
  		
  b45a38fb884fb4a180806456f9c3fdadeecd5916
  David Trowbridge
 


 
  
 
 
  
   
    

     Convert close and reopen operations to return a promise.
     
This change updates the review request close and reopen operations to
use promises instead of callbacks.

Testing Done:
- Ran js-tests.
- Manually tested review request close and reopen.

    

   
  		
  096e4e7edfefded7b1f1fb9abc45f2174c4e8723
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/resources/models/reviewRequestModel.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/resources/models/tests/reviewRequestModelTests.es6.js
     
    

   
  

 










     

    

   

  

  

   
   Loading...