Convert close and reopen operations to return a promise.

Review Request #11636 — Created May 28, 2021 and submitted — Latest diff uploaded

Information

Review Board
master

Reviewers

This change updates the review request close and reopen operations to
use promises instead of callbacks.

  • Ran js-tests.
  • Manually tested review request close and reopen.

Changes between revision 1 and 2

orig
1
2
3
4
5

Commits

Summary ID Author
Convert close and reopen operations to return a promise.
This change updates the review request close and reopen operations to use promises instead of callbacks. Testing Done: - Ran js-tests. - Manually tested review request close and reopen.
5fdd8343c9effb18f6f75e8ae147529daa9e1e1b David Trowbridge
Convert close and reopen operations to return a promise.
This change updates the review request close and reopen operations to use promises instead of callbacks. Testing Done: - Ran js-tests. - Manually tested review request close and reopen.
b45a38fb884fb4a180806456f9c3fdadeecd5916 David Trowbridge
reviewboard/static/rb/js/resources/models/reviewRequestModel.es6.js
reviewboard/static/rb/js/resources/models/tests/reviewRequestModelTests.es6.js
reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js
Loading...